mirror of
https://github.com/spotipy-dev/spotipy.git
synced 2026-04-26 16:15:51 +03:00
[GH-ISSUE #753] albums endpoint should have country/market param #457
Labels
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotipy#457
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jadenmazzone on GitHub (Dec 9, 2021).
Original GitHub issue: https://github.com/spotipy-dev/spotipy/issues/753
Very simple but the albums(albums) endpoint should be albums(albums, country). According to Spotify Get Several Albums.
@stephanebruckert commented on GitHub (Dec 9, 2021):
Can you please elaborate on:
@jadenmazzone commented on GitHub (Dec 9, 2021):
This is the endpoint on spotify: https://developer.spotify.com/console/get-several-albums/. As you can see they have a "market" parameter. So I'm saying that this needs to be added to the "albums" endpoint.
@jadenmazzone commented on GitHub (Dec 9, 2021):
Just "album" is also missing a market/country param.
@stephanebruckert commented on GitHub (Dec 9, 2021):
You probably refer to
Spotify.albumsorSpotify.albumwhich both look for specific album(s) while themarketparameter already exists on the album search method https://spotipy.readthedocs.io/en/2.19.0/#spotipy.client.Spotify.artist_albums, see thecountryparameter@jadenmazzone commented on GitHub (Dec 9, 2021):
Those are different endpoints...Artist_albums does not give any track information while spotify albums / album does, therefore have different responses / data. https://spotipy.readthedocs.io/en/2.19.0/#spotipy.client.Spotify.albums and https://spotipy.readthedocs.io/en/2.19.0/#spotipy.client.Spotify.album should have a "country" param.
@stephanebruckert commented on GitHub (Dec 9, 2021):
Oh sorry you are correct, I thought you linked to https://developer.spotify.com/console/get-artist-albums/
Yes,
github.com/plamere/spotipy@a81aa595ba/spotipy/client.py (L449)is missing a
marketparameter according to https://developer.spotify.com/console/get-several-albums/Same for:
github.com/plamere/spotipy@a81aa595ba/spotipy/client.py (L423)according to https://developer.spotify.com/console/get-album/
@jadenmazzone commented on GitHub (Apr 27, 2022):
Has this been added yet?