starred/spotipy
1
0
Fork 0
mirror of https://github.com/spotipy-dev/spotipy.git synced 2026-04-26 16:15:51 +03:00
Code Issues 62 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #717] Exponential backoff timer #431

New issue
Closed
opened 2026-02-27 23:22:36 +03:00 by kerem · 3 comments
kerem commented 2026-02-27 23:22:36 +03:00
Owner
Copy link

Originally created by @systemcrash on GitHub (Aug 18, 2021).
Original GitHub issue: https://github.com/spotipy-dev/spotipy/issues/717

Is your feature request related to a problem? Please describe.
HASS spams the API endpoint with multiple worker threads, despite continuous 429 responses.

Describe the solution you'd like
How about an exponential back-off timer?

Describe alternatives you've considered
Death. 💀

Additional context
HASS approach is to turn a bit of a blind eye here, e.g. https://github.com/home-assistant/core/issues/53776 and who can blame them when they suspect that it's a Spotify issue.

To alleviate the risk of hidden bugs here or there or anywhere, try an exponential backoff.

I was not able to remove and re-add the Spotify add-on in HASS, until

  1. completely having removed the extension
  2. having waited for about 15-20 minutes
  3. trying again anew

The 429s may be rooted in another problem on their side if they do not provide an adequate Retry-After: header. But I don't want to get banned from the API endpoint, nor would HASS want to, so a logarithmic back-off would be reassuring.

If multiple workers run spotipy to retry, it might be a futile effort (since there may be overlap of retry via HASS worker threads), but if the existing thread backs off, it should help.


ERROR (SyncWorker_6) [spotipy.client] Max Retries reached
WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds
WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30
ERROR (SyncWorker_7) [spotipy.client] Max Retries reached
WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds
WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30
ERROR (SyncWorker_1) [spotipy.client] Max Retries reached
WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds
WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30
ERROR (SyncWorker_1) [spotipy.client] Max Retries reached
WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds
WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30
ERROR (SyncWorker_8) [spotipy.client] Max Retries reached
WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds
WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30
ERROR (SyncWorker_6) [spotipy.client] Max Retries reached
WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds
WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30
ERROR (SyncWorker_2) [spotipy.client] Max Retries reached
WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds
WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30
ERROR (SyncWorker_4) [spotipy.client] Max Retries reached
WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds
WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30
ERROR (SyncWorker_2) [spotipy.client] Max Retries reached
WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds
WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30
ERROR (SyncWorker_8) [spotipy.client] Max Retries reached
WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds
WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30
ERROR (SyncWorker_8) [spotipy.client] Max Retries reached
WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds
WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30
ERROR (SyncWorker_2) [spotipy.client] Max Retries reached
WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds
Originally created by @systemcrash on GitHub (Aug 18, 2021). Original GitHub issue: https://github.com/spotipy-dev/spotipy/issues/717 **Is your feature request related to a problem? Please describe.** HASS spams the API endpoint with multiple worker threads, despite continuous 429 responses. **Describe the solution you'd like** How about an exponential back-off timer? **Describe alternatives you've considered** Death. 💀 **Additional context** HASS approach is to turn a bit of a blind eye here, e.g. https://github.com/home-assistant/core/issues/53776 and who can blame them when they suspect that it's a Spotify issue. To alleviate the risk of hidden bugs here or there or anywhere, try an exponential backoff. I was not able to remove and re-add the Spotify add-on in HASS, until 1) completely having removed the extension 2) having waited for about 15-20 minutes 3) trying again anew The 429s may be rooted in another problem on their side if they do not provide an adequate `Retry-After:` header. But I don't want to get banned from the API endpoint, nor would HASS want to, so a logarithmic back-off would be reassuring. If multiple workers run spotipy to retry, it might be a futile effort (since there may be overlap of retry via HASS worker threads), but if the existing thread backs off, it should help. ``` ERROR (SyncWorker_6) [spotipy.client] Max Retries reached WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30 ERROR (SyncWorker_7) [spotipy.client] Max Retries reached WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30 ERROR (SyncWorker_1) [spotipy.client] Max Retries reached WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30 ERROR (SyncWorker_1) [spotipy.client] Max Retries reached WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30 ERROR (SyncWorker_8) [spotipy.client] Max Retries reached WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30 ERROR (SyncWorker_6) [spotipy.client] Max Retries reached WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30 ERROR (SyncWorker_2) [spotipy.client] Max Retries reached WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30 ERROR (SyncWorker_4) [spotipy.client] Max Retries reached WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30 ERROR (SyncWorker_2) [spotipy.client] Max Retries reached WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30 ERROR (SyncWorker_8) [spotipy.client] Max Retries reached WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30 ERROR (SyncWorker_8) [spotipy.client] Max Retries reached WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds WARNING (MainThread) [homeassistant.components.media_player] Updating spotify media_player took longer than the scheduled update interval 0:00:30 ERROR (SyncWorker_2) [spotipy.client] Max Retries reached WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.spotify_blah_blah is taking over 10 seconds ```
kerem 2026-02-27 23:22:36 +03:00
kerem commented 2026-02-27 23:22:36 +03:00
Author
Owner
Copy link

@systemcrash commented on GitHub (Aug 18, 2021):

Oops - I see it's already there......

<!-- gh-comment-id:901062091 --> @systemcrash commented on GitHub (Aug 18, 2021): Oops - I see it's already there......
kerem commented 2026-02-27 23:22:36 +03:00
Author
Owner
Copy link

@systemcrash commented on GitHub (Aug 18, 2021):

Is it possible that the Retry-After header contains an http-date and not just delay-seconds ?

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Retry-After

In which case it is the responsibility of urllib3?

<!-- gh-comment-id:901063242 --> @systemcrash commented on GitHub (Aug 18, 2021): Is it possible that the Retry-After header contains an http-date and not just delay-seconds ? https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Retry-After In which case it is the responsibility of urllib3?
kerem commented 2026-02-27 23:22:36 +03:00
Author
Owner
Copy link

@systemcrash commented on GitHub (Aug 18, 2021):

Nope - they support it. Hmmmm.

<!-- gh-comment-id:901065960 --> @systemcrash commented on GitHub (Aug 18, 2021): Nope - they support it. Hmmmm.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feature/2026-02-changes
feature/invalid-uri-warning
feature/refresh-endpoints
doc-deprecations
revert-synchronize
v3
run-tests
bugfix/1149-change-cache-name
2.23.0
v3_oldprsonly
2.26.0
2.25.2
2.25.1
2.25.0
2.24.0
2.23.0
2.22.1
2.22.0
2.21.0
2.20.0
2.19.0
2.18.0
2.17.1
2.17.0
2.16.1
2.16.0
2.15.0
2.14.0
2.13.0
2.12.0
2.11.2
2.11.1
2.11.0
2.10.0
2.9.0
2.8.0
2.7.1
2.7.0
2.6.3
2.6.2
2.6.1
2.6.0
2.5.0
Labels
Clear labels   
api-bug

   
bug

   
dependencies

   
documentation

   
duplicate

   
enhancement

   
external-ide

   
headless-mode

   
implicit-grant-flow

   
invalid

   
missing-endpoint

   
pr-welcome

   
private-api

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
spotipy3

   
wontfix
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotipy#431
No description provided.