mirror of
https://github.com/spotipy-dev/spotipy.git
synced 2026-04-27 00:25:54 +03:00
[GH-ISSUE #658] Redirect page does not automatically close. #391
Labels
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotipy#391
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MartijnVogelaar on GitHub (Mar 22, 2021).
Original GitHub issue: https://github.com/spotipy-dev/spotipy/issues/658
Describe the bug
Using the oath2 module the user is eventually redirected to the redirect page which should close automatically or should be closed by a click on a button. It however does not work and throws the following error in the browser's console:
In the following piece of code:
github.com/plamere/spotipy@dc89a00113/spotipy/oauth2.py (L1282-L1293)the page tries to close itself by doing a window.close() on line 1282 and also tries to add a button on line 1292 which should close the current window, but it does not.
This is the case in both Chromium-based browsers as in Firefox see: firefox definition .
This behavior is confusing for some users, someone opened an issue on my project regarding this: https://github.com/MartijnVogelaar/krunner-spotify/issues/26
``
Your code
Expected behavior
The expected result is obviously that the window is automatically closed, or closed by clicking the button.
Output
As said earlier the browser console outputs:
Environment:
Suggestion
I would suggest to just remove the entire button and tell the user that the window can be closed by the user.
@dieser-niko commented on GitHub (May 1, 2024):
Closing as there's no activity (and also it seems to be fixed).