starred/spotipy
1
0
Fork 0
mirror of https://github.com/spotipy-dev/spotipy.git synced 2026-04-27 00:25:54 +03:00
Code Issues 62 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #581] Multiple errors thrown on reaching max retries by #580 #346

New issue
Closed
opened 2026-02-27 23:22:07 +03:00 by kerem · 4 comments
kerem commented 2026-02-27 23:22:07 +03:00
Owner
Copy link

Originally created by @Quizz1Cal on GitHub (Oct 5, 2020).
Original GitHub issue: https://github.com/spotipy-dev/spotipy/issues/581

NOTE: My first issue to a public repo, any feedback is appreciated :)

Describe the bug
Using spotipy post-#580 (relevant issue #571 ) yields uncaught urllib3 / requests library errors, and in particular an AttributeError due to retry_error.response being None (see below). Furthermore, though not featured below, line 274 of client.py under this commit will also throw an AttributeError for the same reason.

Your code
Note: Have defined environment variables SPOTIPY_CLIENT_ID, SPOTIPY_CLIENT_SECRET, SPOTIPY_CLIENT_USERNAME and SPOTIPY_REDIRECT_URI.

# GetClientCredentials() also works here, the playlist is public
spotify = Spotify(auth_manager=SpotifyOAuth(scope='playlist-read-private'))
brain_food_playlist_id = '37i9dQZF1DWXLeA8Omikj7'
playlist = spotify.playlist(playlist_id=brain_food_playlist_id)
print(spotify.playlist_is_following(playlist_id=playlist['id'], user_ids=['spotify:user:bad_username']))

Expected behavior
According to the implementation of the requests library, responses are expected to not be passed to RetryErrors (see source code here; AFAIK this is the only circumstance it is thrown by the library).

Therefore, it is my belief that:

  1. A SpotifyException should be thrown (potentially, with the associated url and header, if retrievable)
  2. (if would not unreasonably impact existing behaviour) The non-spotipy exceptions should not be thrown

Output
WARNING: Paths modified for privacy

Max Retries reached
Traceback (most recent call last):
  File "../project/venv/lib/python3.8/site-packages/requests/adapters.py", line 439, in send
    resp = conn.urlopen(
  File "../project/venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 817, in urlopen
    return self.urlopen(
  File "../project/venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 817, in urlopen
    return self.urlopen(
  File "../project/venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 817, in urlopen
    return self.urlopen(
  File "../project/venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 807, in urlopen
    retries = retries.increment(method, url, response=response, _pool=self)
  File "../project/venv/lib/python3.8/site-packages/urllib3/util/retry.py", line 439, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='api.spotify.com', port=443): Max retries exceeded with url: /v1/playlists/37i9dQZF1DWXLeA8Omikj7/followers/contains?ids=spotify:user:bad_fakename (Caused by ResponseError('too many 500 error responses'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "../project/venv/lib/python3.8/site-packages/spotipy/client.py", line 239, in _internal_call
    response = self._session.request(
  File "../project/venv/lib/python3.8/site-packages/requests/sessions.py", line 530, in request
    resp = self.send(prep, **send_kwargs)
  File "../project/venv/lib/python3.8/site-packages/requests/sessions.py", line 643, in send
    r = adapter.send(request, **kwargs)
  File "../project/venv/lib/python3.8/site-packages/requests/adapters.py", line 507, in send
    raise RetryError(e, request=request)
requests.exceptions.RetryError: HTTPSConnectionPool(host='api.spotify.com', port=443): Max retries exceeded with url: /v1/playlists/37i9dQZF1DWXLeA8Omikj7/followers/contains?ids=spotify:user:bad_fakename (Caused by ResponseError('too many 500 error responses'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "../project/src/issue_boilerplate.py", line 10, in <module>
    print(spotify.playlist_is_following(playlist_id=playlist['id'], user_ids=['spotify:user:bad_fakename']))
  File "../project/venv/lib/python3.8/site-packages/spotipy/client.py", line 1145, in playlist_is_following
    return self._get(
  File "../project/venv/lib/python3.8/site-packages/spotipy/client.py", line 286, in _get
    return self._internal_call("GET", url, payload, kwargs)
  File "../project/venv/lib/python3.8/site-packages/spotipy/client.py", line 273, in _internal_call
    "%s:\n %s" % (response.url, "Max Retries"),
AttributeError: 'NoneType' object has no attribute 'url'

Environment:

  • OS: Ubuntu 20.04.1 LTS
  • Python version: 3.8.2
  • spotipy version: Commit 18e82b6625 (#580 )
  • your IDE: xterm
Originally created by @Quizz1Cal on GitHub (Oct 5, 2020). Original GitHub issue: https://github.com/spotipy-dev/spotipy/issues/581 *NOTE: My first issue to a public repo, any feedback is appreciated :)* **Describe the bug** Using spotipy post-#580 (relevant issue #571 ) yields uncaught urllib3 / requests library errors, and in particular an AttributeError due to `retry_error.response` being None (see below). Furthermore, though not featured below, line 274 of client.py under this commit will also throw an AttributeError for the same reason. **Your code** *Note*: Have defined environment variables `SPOTIPY_CLIENT_ID`, `SPOTIPY_CLIENT_SECRET`, `SPOTIPY_CLIENT_USERNAME` and `SPOTIPY_REDIRECT_URI`. ```python # GetClientCredentials() also works here, the playlist is public spotify = Spotify(auth_manager=SpotifyOAuth(scope='playlist-read-private')) brain_food_playlist_id = '37i9dQZF1DWXLeA8Omikj7' playlist = spotify.playlist(playlist_id=brain_food_playlist_id) print(spotify.playlist_is_following(playlist_id=playlist['id'], user_ids=['spotify:user:bad_username'])) ``` **Expected behavior** According to the implementation of the `requests` library, responses are expected to not be passed to RetryErrors ([see source code here](https://github.com/psf/requests/blob/master/requests/adapters.py#L507); AFAIK this is the only circumstance it is thrown by the library). Therefore, it is my belief that: 1. A SpotifyException should be thrown (potentially, with the associated url and header, if retrievable) 2. (if would not unreasonably impact existing behaviour) The non-spotipy exceptions should not be thrown **Output** **WARNING**: Paths modified for privacy ``` Max Retries reached Traceback (most recent call last): File "../project/venv/lib/python3.8/site-packages/requests/adapters.py", line 439, in send resp = conn.urlopen( File "../project/venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 817, in urlopen return self.urlopen( File "../project/venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 817, in urlopen return self.urlopen( File "../project/venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 817, in urlopen return self.urlopen( File "../project/venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 807, in urlopen retries = retries.increment(method, url, response=response, _pool=self) File "../project/venv/lib/python3.8/site-packages/urllib3/util/retry.py", line 439, in increment raise MaxRetryError(_pool, url, error or ResponseError(cause)) urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='api.spotify.com', port=443): Max retries exceeded with url: /v1/playlists/37i9dQZF1DWXLeA8Omikj7/followers/contains?ids=spotify:user:bad_fakename (Caused by ResponseError('too many 500 error responses')) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "../project/venv/lib/python3.8/site-packages/spotipy/client.py", line 239, in _internal_call response = self._session.request( File "../project/venv/lib/python3.8/site-packages/requests/sessions.py", line 530, in request resp = self.send(prep, **send_kwargs) File "../project/venv/lib/python3.8/site-packages/requests/sessions.py", line 643, in send r = adapter.send(request, **kwargs) File "../project/venv/lib/python3.8/site-packages/requests/adapters.py", line 507, in send raise RetryError(e, request=request) requests.exceptions.RetryError: HTTPSConnectionPool(host='api.spotify.com', port=443): Max retries exceeded with url: /v1/playlists/37i9dQZF1DWXLeA8Omikj7/followers/contains?ids=spotify:user:bad_fakename (Caused by ResponseError('too many 500 error responses')) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "../project/src/issue_boilerplate.py", line 10, in <module> print(spotify.playlist_is_following(playlist_id=playlist['id'], user_ids=['spotify:user:bad_fakename'])) File "../project/venv/lib/python3.8/site-packages/spotipy/client.py", line 1145, in playlist_is_following return self._get( File "../project/venv/lib/python3.8/site-packages/spotipy/client.py", line 286, in _get return self._internal_call("GET", url, payload, kwargs) File "../project/venv/lib/python3.8/site-packages/spotipy/client.py", line 273, in _internal_call "%s:\n %s" % (response.url, "Max Retries"), AttributeError: 'NoneType' object has no attribute 'url' ``` **Environment:** - OS: Ubuntu 20.04.1 LTS - Python version: 3.8.2 - spotipy version: Commit 18e82b6625ca1102c12da08194c806f0fc78f56a (#580 ) - your IDE: xterm
kerem 2026-02-27 23:22:07 +03:00
  • closed this issue
  • added the
    bug
         label
kerem commented 2026-02-27 23:22:08 +03:00
Author
Owner
Copy link

@stephanebruckert commented on GitHub (Oct 5, 2020):

Hi @Quizz1Cal, thanks for the nice report.

In your opinion would reverting https://github.com/plamere/spotipy/pull/580 and re-opening https://github.com/plamere/spotipy/issues/571 help? Also if you feel confident to write a fix for this, that would be really appreciated 🙏

<!-- gh-comment-id:703808171 --> @stephanebruckert commented on GitHub (Oct 5, 2020): Hi @Quizz1Cal, thanks for the nice report. In your opinion would reverting https://github.com/plamere/spotipy/pull/580 and re-opening https://github.com/plamere/spotipy/issues/571 help? Also if you feel confident to write a fix for this, that would be really appreciated 🙏
kerem commented 2026-02-27 23:22:08 +03:00
Author
Owner
Copy link

@Quizz1Cal commented on GitHub (Oct 5, 2020):

In the sense that #580 does not spiritually resolve #571, perhaps a revert would be best.

In terms of a fix, I'm basically already there so going the full distance should be fine! It comes down to what you'd want to see in a thrown SpotifyException. I can extract the true url from https://api.spotify.com/{v1/etc...} from the error.request.url, which I presume would always equal to response.url. Shouldn't be hard to catch the other exceptions, but can you confirm it would be appropriate to catch or otherwise avoid throwing the urllib3 / requests library errors?

If you approve the PR, would you be willing to label it as hacktoberfest-accepted? (It's not the reason I'm using spotipy, so I'll still fix it regardless :) )

<!-- gh-comment-id:703942211 --> @Quizz1Cal commented on GitHub (Oct 5, 2020): In the sense that #580 does not spiritually resolve #571, perhaps a revert would be best. In terms of a fix, I'm basically already there so going the full distance should be fine! It comes down to what you'd want to see in a thrown SpotifyException. I can extract the true url from https://api.spotify.com/{v1/etc...} from the `error.request.url`, which I presume would always equal to response.url. Shouldn't be hard to catch the other exceptions, but can you confirm it would be appropriate to catch or otherwise avoid throwing the urllib3 / requests library errors? If you approve the PR, would you be willing to label it as hacktoberfest-accepted? (It's not the reason I'm using spotipy, so I'll still fix it regardless :) )
kerem commented 2026-02-27 23:22:08 +03:00
Author
Owner
Copy link

@Quizz1Cal commented on GitHub (Oct 6, 2020):

I've developed a fix:

# ... spotipy/client.py line 267
except requests.exceptions.RetryError as retry_error:
    request = retry_error.request
    logger.error('Max Retries reached')
    try:
        reason = retry_error.args[0].reason
    except (IndexError, AttributeError):
        reason = None
    raise SpotifyException(
        599,
        -1,
        "%s:\n %s" % (request.path_url, "Max Retries"),
        reason=reason
    )

I have only attempted action (1) from above; it should be noted that catching the SpotifyException itself here will silence all aforementioned errors.

I'm not sure if I should open a PR if you haven't yet reverted #580 , so I figure I'd post the minor change here for now. It passes all tests, though I don't believe we have any tests to deal with this specific issue. Perhaps something to add?

<!-- gh-comment-id:704028112 --> @Quizz1Cal commented on GitHub (Oct 6, 2020): I've developed a fix: ```python3 # ... spotipy/client.py line 267 except requests.exceptions.RetryError as retry_error: request = retry_error.request logger.error('Max Retries reached') try: reason = retry_error.args[0].reason except (IndexError, AttributeError): reason = None raise SpotifyException( 599, -1, "%s:\n %s" % (request.path_url, "Max Retries"), reason=reason ) ``` I have only attempted action (1) from above; it should be noted that catching the SpotifyException itself here will silence all aforementioned errors. I'm not sure if I should open a PR if you haven't yet reverted #580 , so I figure I'd post the minor change here for now. It passes all tests, though I don't believe we have any tests to deal with this specific issue. Perhaps something to add?
kerem commented 2026-02-27 23:22:08 +03:00
Author
Owner
Copy link

@stephanebruckert commented on GitHub (Oct 6, 2020):

In the sense that #580 does not spiritually resolve #571, perhaps a revert would be best.

I reverted https://github.com/plamere/spotipy/pull/580 in https://github.com/plamere/spotipy/pull/582 and reopened the initial issue https://github.com/plamere/spotipy/issues/571. In your PR, feel free to solve both #571 and #581

If you approve the PR, would you be willing to label it as hacktoberfest-accepted?

Definitely!

can you confirm it would be appropriate to catch or otherwise avoid throwing the urllib3 / requests library errors

Your fix looks good, displaying retry_error.request.path_url as part of a SpotifyException totally makes sense.

It passes all tests, though I don't believe we have any tests to deal with this specific issue. Perhaps something to add?

Yes integration tests might not consistently test this. If you find a way to unit test/mock it, that'd be amazing, otherwise feel free to submit the PR without it. On my side I'll be testing this manually to make sure it's all good.

<!-- gh-comment-id:704094841 --> @stephanebruckert commented on GitHub (Oct 6, 2020): > In the sense that #580 does not spiritually resolve #571, perhaps a revert would be best. I reverted https://github.com/plamere/spotipy/pull/580 in https://github.com/plamere/spotipy/pull/582 and reopened the initial issue https://github.com/plamere/spotipy/issues/571. In your PR, feel free to solve both #571 and #581 > If you approve the PR, would you be willing to label it as hacktoberfest-accepted? Definitely! > can you confirm it would be appropriate to catch or otherwise avoid throwing the urllib3 / requests library errors Your fix looks good, displaying `retry_error.request.path_url` as part of a SpotifyException totally makes sense. > It passes all tests, though I don't believe we have any tests to deal with this specific issue. Perhaps something to add? Yes integration tests might not consistently test this. If you find a way to unit test/mock it, that'd be amazing, otherwise feel free to submit the PR without it. On my side I'll be testing this manually to make sure it's all good.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feature/2026-02-changes
feature/invalid-uri-warning
feature/refresh-endpoints
doc-deprecations
revert-synchronize
v3
run-tests
bugfix/1149-change-cache-name
2.23.0
v3_oldprsonly
2.26.0
2.25.2
2.25.1
2.25.0
2.24.0
2.23.0
2.22.1
2.22.0
2.21.0
2.20.0
2.19.0
2.18.0
2.17.1
2.17.0
2.16.1
2.16.0
2.15.0
2.14.0
2.13.0
2.12.0
2.11.2
2.11.1
2.11.0
2.10.0
2.9.0
2.8.0
2.7.1
2.7.0
2.6.3
2.6.2
2.6.1
2.6.0
2.5.0
Labels
Clear labels   
api-bug

   
bug

   
dependencies

   
documentation

   
duplicate

   
enhancement

   
external-ide

   
headless-mode

   
implicit-grant-flow

   
invalid

   
missing-endpoint

   
pr-welcome

   
private-api

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
spotipy3

   
wontfix
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotipy#346
No description provided.