mirror of
https://github.com/spotipy-dev/spotipy.git
synced 2026-04-26 16:15:51 +03:00
[GH-ISSUE #307] user id's are not URL percent encoded #176
Labels
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotipy#176
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @william-reed on GitHub (Jul 3, 2018).
Original GitHub issue: https://github.com/spotipy-dev/spotipy/issues/307
user id's are not URL encoded and results in some 404 errors when usernames contain symbols. Can be solved simply by using
urllib.parser.quotebut it seems this repository is no longer updated so I am posting this more as a public service announcement than anything else.@stephanebruckert commented on GitHub (Jan 12, 2020):
To review https://github.com/plamere/spotipy/pull/350/
@MaZderMind commented on GitHub (Jan 22, 2020):
This can be easily triggered by using the E-Mail-Address as Username, which works for all calls that do not pass the username as an argument.
@ritiek commented on GitHub (Jan 23, 2020):
It'd be nice if someone can provide an example method where this issue can be replicated. I tried passing username and email address to
sp.user(), but it seems to fail for email address both with or without percent encoding. I'm probably doing something wrong I think.@MaZderMind commented on GitHub (Jan 23, 2020):
I triggered it by running the test-suite with an email-address as username.
@ghost commented on GitHub (Apr 14, 2020):
Taking a look at the Spotify API itself, it states that the parameter to the users endpoint must be an userid, so I guess that the email-address will not work even with the encoding.
For the usernames I will try to make an pull request to fix this as soon as I found an userid that contains special characters to test with.
@stephanebruckert commented on GitHub (Apr 15, 2020):
@Bressan09 thanks! Also note that there is https://github.com/plamere/spotipy/pull/350, what do you think of it? I am not sure myself in what scenario this is needed
@stephanebruckert commented on GitHub (Jun 14, 2020):
Closing this as I don't think Spotify allows emails as possible usernames anymore