[PR #1222] fix: dont override verify attribute when requesting access token #1220

Open
opened 2026-02-28 00:04:09 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/spotipy-dev/spotipy/pull/1222
Author: @sigma67
Created: 12/22/2025
Status: 🔄 Open

Base: masterHead: fix-override-verify-clientcredentials


📝 Commits (3)

  • 50f08e3 fix: dont override verify attribute when requesting access token
  • 316ed32 changelog
  • 5ecf39c try again

📊 Changes

2 files changed (+3 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 spotipy/oauth2.py (+0 -1)

📄 Description

This call is the only one that overrides the _session.verify which can be passed in via the arguments of SpotifyClientCredentials.

This makes it impossible to actually disable cert verification or set a custom certificate chain (i.e. in a corporate network).

Hence this line should be removed and use the default settings instead, which are provided by the caller.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/spotipy-dev/spotipy/pull/1222 **Author:** [@sigma67](https://github.com/sigma67) **Created:** 12/22/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-override-verify-clientcredentials` --- ### 📝 Commits (3) - [`50f08e3`](https://github.com/spotipy-dev/spotipy/commit/50f08e31860dff661905ae01d04db2817742a00c) fix: dont override verify attribute when requesting access token - [`316ed32`](https://github.com/spotipy-dev/spotipy/commit/316ed324d24a44b385f63e2b98e53420302ec230) changelog - [`5ecf39c`](https://github.com/spotipy-dev/spotipy/commit/5ecf39cf3b2865c8fa81dece7a5d43603c8f8b8c) try again ### 📊 Changes **2 files changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `spotipy/oauth2.py` (+0 -1) </details> ### 📄 Description This call is the only one that overrides the `_session.verify` which can be passed in via the arguments of `SpotifyClientCredentials`. This makes it impossible to actually disable cert verification or set a custom certificate chain (i.e. in a corporate network). Hence this line should be removed and use the default settings instead, which are provided by the caller. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotipy#1220
No description provided.