[PR #1203] Fix indefinite hang on invalid PKCE client_id #1210

New issue

Open

opened 2026-02-28 00:04:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:04:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/spotipy-dev/spotipy/pull/1203
Author: @AtomikkuLabs
Created: 5/26/2025
Status: 🔄 Open

Base: master ← Head: master

📝 Commits (1)

7e40a8e Fix indefinite hang on invalid PKCE client_id

📊 Changes

1 file changed (+21 additions, -0 deletions)

View changed files

📝 spotipy/oauth2.py (+21 -0)

📄 Description

Fixes indefinite hang when an invalid client_id is put into SpotifyPKCE and get_access_token is called. A preflight has been made to test out the client_id beforehand. Not sure if this is the most valid approach but it seems to work and gives a clear error.

PKCE issue was noted by me here

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/spotipy-dev/spotipy/pull/1203 **Author:** [@AtomikkuLabs](https://github.com/AtomikkuLabs) **Created:** 5/26/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`7e40a8e`](https://github.com/spotipy-dev/spotipy/commit/7e40a8e34bd41345a463556176f5d4434661e5d7) Fix indefinite hang on invalid PKCE client_id ### 📊 Changes **1 file changed** (+21 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `spotipy/oauth2.py` (+21 -0) </details> ### 📄 Description Fixes indefinite hang when an invalid client_id is put into SpotifyPKCE and get_access_token is called. A preflight has been made to test out the client_id beforehand. Not sure if this is the most valid approach but it seems to work and gives a clear error. PKCE issue was noted by me [here](https://github.com/spotipy-dev/spotipy/issues/957#issuecomment-2826480651) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>