[PR #901] [MERGED] Update search_markets method to apply the total parameter to all types, add tests #1068

Closed
opened 2026-02-28 00:03:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/spotipy-dev/spotipy/pull/901
Author: @rngolam
Created: 11/28/2022
Status: Merged
Merged: 3/15/2023
Merged by: @stephanebruckert

Base: masterHead: fix/534/apply-search-markets-total-to-all-types


📝 Commits (4)

  • 634fbcc Update search_markets method to apply the total parameter to all types, fixes #534
  • 28441f2 Add integration tests for searching multiple types in multiple markets
  • 8796223 Update search_markets method to apply the total parameter to all types, add tests
  • b48b995 Merge branch 'master' into fix/534/apply-search-markets-total-to-all-types

📊 Changes

3 files changed (+104 additions, -13 deletions)

View changed files

📝 CHANGELOG.md (+3 -2)
📝 spotipy/client.py (+20 -11)
📝 tests/integration/non_user_endpoints/test.py (+81 -0)

📄 Description

Additions

  • Added tests for searching multiple types in multiple markets

Fixes

  • Updated the search_markets method to factor item counts from all search types into the total rather than just the first type (#534)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/spotipy-dev/spotipy/pull/901 **Author:** [@rngolam](https://github.com/rngolam) **Created:** 11/28/2022 **Status:** ✅ Merged **Merged:** 3/15/2023 **Merged by:** [@stephanebruckert](https://github.com/stephanebruckert) **Base:** `master` ← **Head:** `fix/534/apply-search-markets-total-to-all-types` --- ### 📝 Commits (4) - [`634fbcc`](https://github.com/spotipy-dev/spotipy/commit/634fbccc505317b98a4f2fb5e26f8127141acfbe) Update search_markets method to apply the total parameter to all types, fixes #534 - [`28441f2`](https://github.com/spotipy-dev/spotipy/commit/28441f21e80e74acbde2e977715e23263b1fe4be) Add integration tests for searching multiple types in multiple markets - [`8796223`](https://github.com/spotipy-dev/spotipy/commit/8796223c26b0054e51f15a3ab9b56421ce3ede50) Update search_markets method to apply the total parameter to all types, add tests - [`b48b995`](https://github.com/spotipy-dev/spotipy/commit/b48b99572f4210a58e984360f3d999b83b22abb2) Merge branch 'master' into fix/534/apply-search-markets-total-to-all-types ### 📊 Changes **3 files changed** (+104 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -2) 📝 `spotipy/client.py` (+20 -11) 📝 `tests/integration/non_user_endpoints/test.py` (+81 -0) </details> ### 📄 Description **Additions** - Added tests for searching multiple types in multiple markets **Fixes** - Updated the `search_markets` method to factor item counts from all search types into the `total` rather than just the first type (#534) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:03:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotipy#1068
No description provided.