[PR #893] [MERGED] Add tests for global categories, releases, fix bugged tests #1062

New issue

Closed

opened 2026-02-28 00:03:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:03:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/spotipy-dev/spotipy/pull/893
Author: @kevinsekuj
Created: 11/26/2022
Status: ✅ Merged
Merged: 11/26/2022
Merged by: @stephanebruckert

Base: master ← Head: upgrade-unit-tests

📝 Commits (7)

6484be5 Add tests for global categories, releases, fix bugged tests
92e5a0b Update changelog to represent pr changes
a4f8cad Move changes to Unreleased
97c64d0 Modify changelog spacing to be more consistent
8b5fedf Merge branch 'master' into upgrade-unit-tests
01703c1 Remove redundant test
34c03a1 Merge branch 'upgrade-unit-tests' of github.com:kevinsekuj/spotipy into upgrade-unit-tests

📊 Changes

3 files changed (+19 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+4 -0)
📝 tests/integration/non_user_endpoints/test.py (+2 -0)
📝 tests/integration/user_endpoints/test.py (+13 -1)

📄 Description

Additions

Added further unit tests for new releases, passing limit parameter with minimum and maximum values of 1 and 50
Added further unit tests for categories, omitting country code to test global releases

Fixes

Fixed potential error where found variable in test_artist_related_artists tests/integration/non_user_endpoints/test.py is undefined if for loop never evaluates to true
Fixed false positive test test_new_releases which looks up the wrong property of the JSON response object and always evaluates to true

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/spotipy-dev/spotipy/pull/893 **Author:** [@kevinsekuj](https://github.com/kevinsekuj) **Created:** 11/26/2022 **Status:** ✅ Merged **Merged:** 11/26/2022 **Merged by:** [@stephanebruckert](https://github.com/stephanebruckert) **Base:** `master` ← **Head:** `upgrade-unit-tests` --- ### 📝 Commits (7) - [`6484be5`](https://github.com/spotipy-dev/spotipy/commit/6484be5cbb3f1ecc5e2040dfbe55fe33ff661f7c) Add tests for global categories, releases, fix bugged tests - [`92e5a0b`](https://github.com/spotipy-dev/spotipy/commit/92e5a0bc81b8b52a9bd480a17aa852335c5fa7ce) Update changelog to represent pr changes - [`a4f8cad`](https://github.com/spotipy-dev/spotipy/commit/a4f8cadcd8818a86527dfcfdddbc94334cf224a4) Move changes to Unreleased - [`97c64d0`](https://github.com/spotipy-dev/spotipy/commit/97c64d05f61e5ed5831a21f320c386e0eb2d0be5) Modify changelog spacing to be more consistent - [`8b5fedf`](https://github.com/spotipy-dev/spotipy/commit/8b5fedff1fa804c7b3dad0fd04dcaa40f98237d3) Merge branch 'master' into upgrade-unit-tests - [`01703c1`](https://github.com/spotipy-dev/spotipy/commit/01703c1b2ee53e10c2da027e1d68ab280514d70b) Remove redundant test - [`34c03a1`](https://github.com/spotipy-dev/spotipy/commit/34c03a10c4ad483629050439bd7089f71400a0a4) Merge branch 'upgrade-unit-tests' of github.com:kevinsekuj/spotipy into upgrade-unit-tests ### 📊 Changes **3 files changed** (+19 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -0) 📝 `tests/integration/non_user_endpoints/test.py` (+2 -0) 📝 `tests/integration/user_endpoints/test.py` (+13 -1) </details> ### 📄 Description **Additions** - Added further unit tests for new releases, passing limit parameter with minimum and maximum values of 1 and 50 - Added further unit tests for categories, omitting country code to test global releases **Fixes** - Fixed potential error where `found` variable in `test_artist_related_artists` _tests/integration/non_user_endpoints/test.py_ is undefined if for loop never evaluates to true - Fixed false positive test `test_new_releases` which looks up the wrong property of the JSON response object and always evaluates to true --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>