[PR #26] [MERGED] Moved CLEAN_OUTPUT assignment after loading configuration files. Check that it is used only with -l or -x #33

New issue

Closed

opened 2026-02-27 20:07:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:07:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/misiektoja/spotify_profile_monitor/pull/26
Author: @tomballgithub
Created: 7/19/2025
Status: ✅ Merged
Merged: 9/7/2025
Merged by: @tomballgithub

Base: dev ← Head: cleanout

📝 Commits (3)

76e01fd Moved CLEAN_OUTPUT assignment after loading configuration files. Check that it is used only with -l or -x
f845cf7 Added comments back
6e53151 Revert "Added comments back"

📊 Changes

1 file changed (+14 additions, -10 deletions)

View changed files

📝 spotify_profile_monitor.py (+14 -10)

📄 Description

The CLEAN_OUTPUT feature was intended for -l and -x usage, but the code was not checking for that. Fixed this.

The CLEAN_OUTPUT feature was set from command line before the configuration files are loaded. This means the command line argument was unable to override the setting in the configuration files. I moved the code after the configuration files are loaded. The only impact is that the screen clear and printing version info for the script are performed after the configuration files are loaded. If an error occurs during that processing, those messages and sys.exit will occur before the screen is cleared and version printed. It's not a material difference in operation.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/misiektoja/spotify_profile_monitor/pull/26 **Author:** [@tomballgithub](https://github.com/tomballgithub) **Created:** 7/19/2025 **Status:** ✅ Merged **Merged:** 9/7/2025 **Merged by:** [@tomballgithub](https://github.com/tomballgithub) **Base:** `dev` ← **Head:** `cleanout` --- ### 📝 Commits (3) - [`76e01fd`](https://github.com/misiektoja/spotify_profile_monitor/commit/76e01fd0eeec830c848e5021a689739f9bf22051) Moved CLEAN_OUTPUT assignment after loading configuration files. Check that it is used only with -l or -x - [`f845cf7`](https://github.com/misiektoja/spotify_profile_monitor/commit/f845cf7182b63e185742d731beaebe3d8e6d9fdd) Added comments back - [`6e53151`](https://github.com/misiektoja/spotify_profile_monitor/commit/6e53151b7dcfb1719c7b994b50e315de15caddfc) Revert "Added comments back" ### 📊 Changes **1 file changed** (+14 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `spotify_profile_monitor.py` (+14 -10) </details> ### 📄 Description The CLEAN_OUTPUT feature was intended for -l and -x usage, but the code was not checking for that. Fixed this. The CLEAN_OUTPUT feature was set from command line before the configuration files are loaded. This means the command line argument was unable to override the setting in the configuration files. I moved the code after the configuration files are loaded. The only impact is that the screen clear and printing version info for the script are performed after the configuration files are loaded. If an error occurs during that processing, those messages and sys.exit will occur before the screen is cleared and version printed. It's not a material difference in operation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>