mirror of
https://github.com/jwilsson/spotify-web-api-php.git
synced 2026-04-27 16:05:51 +03:00
[GH-ISSUE #17] Adding new 'Follow' endpoints ? #7
Labels
No labels
bug
docs
enhancement
enhancement
enhancement
feedback wanted
good first issue
help wanted
help wanted
help wanted
invalid
pull-request
question
question
upstream
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-web-api-php#7
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @vdesabou on GitHub (Dec 19, 2014).
Original GitHub issue: https://github.com/jwilsson/spotify-web-api-php/issues/17
Hi,
First of all, thanks a lot for your awesome work on this! It's brilliant. (FYI, I'm using it for my repository https://github.com/vdesabou/alfred-spotify-mini-player).
Do you think it would be possible to add the new Follow endpoints at some point ? https://developer.spotify.com/web-api/web-api-follow-endpoints
Thanks
@jwilsson commented on GitHub (Dec 19, 2014):
You're more than welcome to add them 😀
Let me know if you need any pointers.
@vdesabou commented on GitHub (Dec 19, 2014):
I was expecting this answer :)
Ok, I will have a look !
@vdesabou commented on GitHub (Dec 19, 2014):
I have https://developer.spotify.com/web-api/check-current-user-follows/ working.
For https://developer.spotify.com/web-api/follow-artists-users/, I have a problem because the Request.php code assumes when it is a PUT, only data in body is sent.
However, for this new method, 'type' is required in query Parameter, and 'ids' is either in query parameter or request body data. So I don't really know how to add this.
Also we can't move all PUT to query parameters because https://developer.spotify.com/web-api/change-playlist-details/ requires data in request body data.
Any idea?
@jwilsson commented on GitHub (Dec 19, 2014):
Nice!
We could do it in the same way as in
addUserPlaylistTracks()and build the URL manually before sending it toRequest::api().I think we might need to rework the
Requestlogic sometime to handle query strings regardless of HTTP method but let's leave it like this for now.