mirror of
https://github.com/jwilsson/spotify-web-api-php.git
synced 2026-04-26 23:45:49 +03:00
[GH-ISSUE #113] New Refresh Token #68
Labels
No labels
bug
docs
enhancement
enhancement
enhancement
feedback wanted
good first issue
help wanted
help wanted
help wanted
invalid
pull-request
question
question
upstream
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-web-api-php#68
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Hickmeister on GitHub (Jan 2, 2018).
Original GitHub issue: https://github.com/jwilsson/spotify-web-api-php/issues/113
Is there a way to get a new Refresh token after using a previous Refresh token to gain a new Access token?
Because on the Spotify docs it says under the authorization code flow page
refresh_token | string | : "A token that can be sent to the Spotify Accounts service in place of an authorization code. (When the access code expires, send a POST request to the Accounts service /api/token endpoint, but use this code in place of an authorization code. A new access token will be returned. A new refresh token might be returned too.)"
So would a new refresh token be sent aswell?
@jwilsson commented on GitHub (Jan 2, 2018):
Hi!
It seems we missed that part in the
Session::refreshAccessToken()method, so it won't set a new refresh token, if one exists in the response.Would you be interested in submitting a PR and setting a new refresh token if one is included?
@andersborgabiro commented on GitHub (Jan 2, 2018):
Isn't the whole point that a refresh token is a constant? What would be the gain if it changed?
@jwilsson commented on GitHub (Jan 2, 2018):
@andersborgabiro I don't know why a new refresh token would be included (unless it's been revoked for some reason) but I think the server is allowed to decide if it wants to generate a new one or not. So I definitely think we need to support that case.
@andersborgabiro commented on GitHub (Jan 2, 2018):
Understood and agreed.
@jwilsson commented on GitHub (Feb 2, 2018):
A fix for this has been released in
2.1.1.