[PR #283] [MERGED] convert self to static in Request.php #284

New issue

Closed

opened 2026-02-27 19:26:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:26:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jwilsson/spotify-web-api-php/pull/283
Author: @ariaieboy
Created: 1/14/2025
Status: ✅ Merged
Merged: 1/18/2025
Merged by: @jwilsson

Base: main ← Head: static

📝 Commits (1)

d79c35e convert self to static

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/Request.php (+2 -2)

📄 Description

Ok here is the problem.
In some regions spotify blocks the request to bypass it we need to use a proxy.
And for that, we need to change the ACCOUNT_URL and API_URL.
I've extended the Request class and changed those constants. I also passed my custom Request class to the web API.
But since you used self::, it's not inheritance-aware. By using static::, it will be inheritance-aware, and we can change those constants.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jwilsson/spotify-web-api-php/pull/283 **Author:** [@ariaieboy](https://github.com/ariaieboy) **Created:** 1/14/2025 **Status:** ✅ Merged **Merged:** 1/18/2025 **Merged by:** [@jwilsson](https://github.com/jwilsson) **Base:** `main` ← **Head:** `static` --- ### 📝 Commits (1) - [`d79c35e`](https://github.com/jwilsson/spotify-web-api-php/commit/d79c35ed3110d0cabdd6457ba8ba0b376c11ae14) convert self to static ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Request.php` (+2 -2) </details> ### 📄 Description Ok here is the problem. In some regions spotify blocks the request to bypass it we need to use a proxy. And for that, we need to change the `ACCOUNT_URL` and `API_URL`. I've extended the `Request` class and changed those constants. I also passed my custom `Request` class to the web API. But since you used `self::`, it's not inheritance-aware. By using `static::`, it will be inheritance-aware, and we can change those constants. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>