mirror of
https://github.com/jwilsson/spotify-web-api-php.git
synced 2026-04-27 07:55:49 +03:00
[PR #127] [MERGED] Added Authentication specific exception #263
Labels
No labels
bug
docs
enhancement
enhancement
enhancement
feedback wanted
good first issue
help wanted
help wanted
help wanted
invalid
pull-request
question
question
upstream
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-web-api-php#263
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jwilsson/spotify-web-api-php/pull/127
Author: @doekenorg
Created: 6/5/2018
Status: ✅ Merged
Merged: 6/6/2018
Merged by: @jwilsson
Base:
master← Head:feature/AuthException📝 Commits (1)
3d3a9cdAdded Authentication specific exception📊 Changes
3 files changed (+18 additions, -2 deletions)
View changed files
📝
src/Request.php(+9 -1)➕
src/SpotifyWebAPIAuthException.php(+8 -0)📝
tests/RequestTest.php(+1 -1)📄 Description
I would like to be able to catch authentication specific exceptions, so I can automate the refreshing of tokens more easily. I know I have the time when the access token needs to be refreshed, but even then sometimes the token is invalidated earlier, and I get the exception.
Also updated the test so it reflects this change, while making it backwards compatible by extending the original
SpotifyWebAPIException.Please consider a merge. Thanks for the great library!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.