[PR #89] [MERGED] Add typecast to array for implode() #256

New issue

Closed

opened 2026-02-27 19:26:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:26:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jwilsson/spotify-web-api-php/pull/89
Author: @PouleR
Created: 6/12/2017
Status: ✅ Merged
Merged: 6/12/2017
Merged by: @jwilsson

Base: master ← Head: master

📝 Commits (10+)

8833aaf Convert Spotify URIs to Spotify IDs for addMyTracks
94ccd5a Merge pull request #1 from jwilsson/master
f890877 Add type parameter to uriToId method and implement for albums
ab913a4 Merge branch 'master' of https://github.com/jwilsson/spotify-web-api-php into jwilsson-master
0684247 Merge branch 'jwilsson-master'
9b7fdf1 Convert track uri to track id for getTrack() and getTracks() methods
a4d11ce Convert track uri to track id for getAudioFeatures
db8a5f6 Merge pull request #3 from jwilsson/master
bb58686 Add uriToId() to all other applicable methods
2fae6a4 Merge branch 'master' of https://github.com/jwilsson/spotify-web-api-php into jwilsson-master-head

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 src/SpotifyWebAPI.php (+4 -4)

📄 Description

I made a mistake in my previous PR. The method uriToId() can return a string when an array has only one element, therefore the implode function would take place on a string. Now the variable is typecast to an array (as in other methods)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jwilsson/spotify-web-api-php/pull/89 **Author:** [@PouleR](https://github.com/PouleR) **Created:** 6/12/2017 **Status:** ✅ Merged **Merged:** 6/12/2017 **Merged by:** [@jwilsson](https://github.com/jwilsson) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`8833aaf`](https://github.com/jwilsson/spotify-web-api-php/commit/8833aafed46c53a3fc244b50bb1583a085b7b0f5) Convert Spotify URIs to Spotify IDs for addMyTracks - [`94ccd5a`](https://github.com/jwilsson/spotify-web-api-php/commit/94ccd5a44976beb7f256edf2e796ef4484cb2fa7) Merge pull request #1 from jwilsson/master - [`f890877`](https://github.com/jwilsson/spotify-web-api-php/commit/f890877482c712c7bede13ef661a30c906bed07f) Add type parameter to uriToId method and implement for albums - [`ab913a4`](https://github.com/jwilsson/spotify-web-api-php/commit/ab913a45417ce48669188d53c2ffff2ad3610c46) Merge branch 'master' of https://github.com/jwilsson/spotify-web-api-php into jwilsson-master - [`0684247`](https://github.com/jwilsson/spotify-web-api-php/commit/068424754808fc5f328b7ae3b4425462b234f9fa) Merge branch 'jwilsson-master' - [`9b7fdf1`](https://github.com/jwilsson/spotify-web-api-php/commit/9b7fdf1a135480a8bfb808bdeca914782a4ad421) Convert track uri to track id for getTrack() and getTracks() methods - [`a4d11ce`](https://github.com/jwilsson/spotify-web-api-php/commit/a4d11ce81d24029780383f8679e676a498e95def) Convert track uri to track id for getAudioFeatures - [`db8a5f6`](https://github.com/jwilsson/spotify-web-api-php/commit/db8a5f620fd8d3812c6ea46b24a824d538646d85) Merge pull request #3 from jwilsson/master - [`bb58686`](https://github.com/jwilsson/spotify-web-api-php/commit/bb58686fcbe766f4c60340072b173bd934bfd5e0) Add uriToId() to all other applicable methods - [`2fae6a4`](https://github.com/jwilsson/spotify-web-api-php/commit/2fae6a4f7f0399c0e1a8eee30ddaf21c8ee0c2b2) Merge branch 'master' of https://github.com/jwilsson/spotify-web-api-php into jwilsson-master-head ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/SpotifyWebAPI.php` (+4 -4) </details> ### 📄 Description I made a mistake in my previous PR. The method uriToId() can return a string when an array has only one element, therefore the implode function would take place on a string. Now the variable is typecast to an array (as in other methods) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>