mirror of
https://github.com/jwilsson/spotify-web-api-php.git
synced 2026-04-26 23:45:49 +03:00
[PR #61] [MERGED] Add a Request::getLastResponse() method #240
Labels
No labels
bug
docs
enhancement
enhancement
enhancement
feedback wanted
good first issue
help wanted
help wanted
help wanted
invalid
pull-request
question
question
upstream
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-web-api-php#240
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jwilsson/spotify-web-api-php/pull/61
Author: @jwilsson
Created: 12/11/2016
Status: ✅ Merged
Merged: 12/11/2016
Merged by: @jwilsson
Base:
master← Head:request-last-response📝 Commits (3)
6049d09Expose lastResponse in Request1ea0c45Add a SpotifyWebAPI::getRequest() methodcc42b8cAdd docs on error handling📊 Changes
6 files changed (+90 additions, -7 deletions)
View changed files
➕
docs/examples/error-handling.md(+33 -0)📝
docs/examples/index.md(+1 -0)📝
src/Request.php(+30 -7)📝
src/SpotifyWebAPI.php(+10 -0)📝
tests/RequestTest.php(+9 -0)📝
tests/SpotifyWebAPITest.php(+7 -0)📄 Description
Since
SpotifyWebAPI::getLastResponse()isn't available when exceptions are thrown (as noted in #60) I've added a newgetLastResponse()method toRequestas well which will always be populated will the full response.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.