[PR #57] [CLOSED] Fix undefined offset 0 #237

Closed
opened 2026-02-27 19:26:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jwilsson/spotify-web-api-php/pull/57
Author: @jamesfairhurst
Created: 10/26/2016
Status: Closed

Base: masterHead: fix-undefined-offset


📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/SpotifyWebAPI.php (+1 -1)

📄 Description

As the track limit is 100 chunking is needed so array_values just
resets the keys if ever they do not start from 0 e.g. 100+

Could be done app side however this is a bit cleaner, minor change but caused some confusion hunting it down.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jwilsson/spotify-web-api-php/pull/57 **Author:** [@jamesfairhurst](https://github.com/jamesfairhurst) **Created:** 10/26/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-undefined-offset` --- ### 📝 Commits (1) - [`8c788e0`](https://github.com/jwilsson/spotify-web-api-php/commit/8c788e04cf414db5796f2fb780f9f1608da14eb8) Fix undefined offset 0 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/SpotifyWebAPI.php` (+1 -1) </details> ### 📄 Description As the track limit is 100 chunking is needed so array_values just resets the keys if ever they do not start from 0 e.g. 100+ Could be done app side however this is a bit cleaner, minor change but caused some confusion hunting it down. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 19:26:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-web-api-php#237
No description provided.