[PR #19] [MERGED] Renamed refreshToken() and requestToken() to more descriptive names #224

New issue

Closed

opened 2026-02-27 19:26:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:26:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jwilsson/spotify-web-api-php/pull/19
Author: @hvt
Created: 12/23/2014
Status: ✅ Merged
Merged: 3/22/2015
Merged by: @jwilsson

Base: master ← Head: consistent_function_names

📝 Commits (4)

7b6f31a Renamed Session::refreshToken() and Session::requestToken() to more descriptive names
141d9c9 Clarified Session::requestRefreshAndAccessToken() parameter name plus updated some method descriptions
2795f20 oops
98c4a2a Session::requestRefreshAndAccessToken() -> Session::requestAccessToken()

📊 Changes

6 files changed (+96 additions, -59 deletions)

View changed files

📝 README.md (+4 -7)
📝 demo.php (+6 -2)
📝 src/Request.php (+1 -1)
📝 src/Session.php (+39 -20)
📝 src/SpotifyWebAPI.php (+45 -28)
📝 src/SpotifyWebAPIException.php (+1 -1)

📄 Description

Renamed refreshToken() and requestToken() to more descriptive names

Session::refreshToken() -> Session::refreshAccessToken()
Session::requestToken() -> Session::requestRefreshAndAccessToken()
Besides, added E_USER_DEPRECATED errors to both old methods

Updated the demo + docs accordingly
Fixed some CS

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jwilsson/spotify-web-api-php/pull/19 **Author:** [@hvt](https://github.com/hvt) **Created:** 12/23/2014 **Status:** ✅ Merged **Merged:** 3/22/2015 **Merged by:** [@jwilsson](https://github.com/jwilsson) **Base:** `master` ← **Head:** `consistent_function_names` --- ### 📝 Commits (4) - [`7b6f31a`](https://github.com/jwilsson/spotify-web-api-php/commit/7b6f31af4db435f1d3a94bef5758bdf3e864c65a) Renamed Session::refreshToken() and Session::requestToken() to more descriptive names - [`141d9c9`](https://github.com/jwilsson/spotify-web-api-php/commit/141d9c9af464090f59130c696fc39b17ae582ef7) Clarified Session::requestRefreshAndAccessToken() parameter name plus updated some method descriptions - [`2795f20`](https://github.com/jwilsson/spotify-web-api-php/commit/2795f20b20abe0a1a66265853b8b4952c27a3aab) oops - [`98c4a2a`](https://github.com/jwilsson/spotify-web-api-php/commit/98c4a2a5b58e939bcfeba6ed72d07776c717698a) Session::requestRefreshAndAccessToken() -> Session::requestAccessToken() ### 📊 Changes **6 files changed** (+96 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+4 -7) 📝 `demo.php` (+6 -2) 📝 `src/Request.php` (+1 -1) 📝 `src/Session.php` (+39 -20) 📝 `src/SpotifyWebAPI.php` (+45 -28) 📝 `src/SpotifyWebAPIException.php` (+1 -1) </details> ### 📄 Description Renamed refreshToken() and requestToken() to more descriptive names - Session::refreshToken() -> Session::refreshAccessToken() - Session::requestToken() -> Session::requestRefreshAndAccessToken() - Besides, added E_USER_DEPRECATED errors to both old methods Updated the demo + docs accordingly Fixed some CS --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>