mirror of
https://github.com/jwilsson/spotify-web-api-php.git
synced 2026-04-26 23:45:49 +03:00
[GH-ISSUE #33] Naming of playlist-methods #16
Labels
No labels
bug
docs
enhancement
enhancement
enhancement
feedback wanted
good first issue
help wanted
help wanted
help wanted
invalid
pull-request
question
question
upstream
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-web-api-php#16
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jwilsson on GitHub (May 2, 2015).
Original GitHub issue: https://github.com/jwilsson/spotify-web-api-php/issues/33
We've got a bunch of playlist related methods:
addUserPlaylistTracks()createUserPlaylist()deletePlaylistTracks()followPlaylist()getCategoryPlaylists()getFeaturedPlaylists()getUserPlaylist()getUserPlaylists()getUserPlaylistTracks()reorderPlaylistTracks()replacePlaylistTracks()unfollowPlaylist()updateUserPlaylist()Some include "user", some don't. Some shouldn't, like
getCategoryPlaylists()andgetFeaturedPlaylists()but I've included them for the sake of completeness.Now, I think the methods should have a consistent naming. I.e. either all of them should include "user" or none of them should include "user". Perhaps it's best to include "user" in all of them since they operate on a user's playlist but what do others think?
Let the discussion begin!
@jwilsson commented on GitHub (Jul 6, 2015):
deletePlaylistTracks(),reorderPlaylistTracks(), andreplacePlaylistTracks()have been renamed to include "User" in their names. See8768328aee,2ce8fc51cc, and6362510344, respectively.followPlaylist()andunfollowPlaylist()will be left as-is for now.