[PR #651] Viz scripts #954

New issue

Open

opened 2026-02-28 14:53:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:53:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/651
Author: @dmadisetti
Created: 11/5/2020
Status: 🔄 Open

Base: master ← Head: master

📝 Commits (10+)

5edb93c Analysis done in script
3f2d081 Merge res and file addition
1d4875b file format
6d9f229 Merge branch 'master' of https://github.com/Rigellute/spotify-tui into merge-res
93188b0 merge res
e17b904 Added vis script
8cc1299 Satisfy clippy
bfd2c46 Errors (#2)
1cc0dbc Merge branch 'master' of https://github.com/AnotherGroupChat/spotify-tui
427f037 Move vis into engine instead of just compiling the ast

📊 Changes

9 files changed (+526 additions, -142 deletions)

View changed files

📝 Cargo.lock (+29 -2)
📝 Cargo.toml (+1 -0)
📝 src/app.rs (+56 -0)
➕ src/error.rs (+35 -0)
📝 src/main.rs (+12 -1)
📝 src/ui/audio_analysis.rs (+145 -73)
📝 src/user_config.rs (+148 -20)
📝 src/util.rs (+46 -46)
➕ visulizations/keys.rhai (+54 -0)

📄 Description

Just wanted to follow up on https://github.com/Rigellute/spotify-tui/issues/613#issuecomment-707580846
This needs a ton of cleaning, just got it to a place where it runs.
Notably:

break up audio_analysis
Abstract out some of the rhai evaluation
Allow for more than bar charts
use raw engine over full engine for rhai
Create plugin dir and init with default plugins
change Result<Thing, String> -> Result<Thing, VizError>`
standardize some of the variables names etc..
write documentation

Maybe in another PR

Allow for plugin change during run
Allow for plugin reload

And then

Allow for basic mode w/o analysis

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/651 **Author:** [@dmadisetti](https://github.com/dmadisetti) **Created:** 11/5/2020 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`5edb93c`](https://github.com/Rigellute/spotify-tui/commit/5edb93cf1d82b3c19ca40c11bb5bf8d6b00f4132) Analysis done in script - [`3f2d081`](https://github.com/Rigellute/spotify-tui/commit/3f2d0816427a77235c281eaa1cc17578e3814bbf) Merge res and file addition - [`1d4875b`](https://github.com/Rigellute/spotify-tui/commit/1d4875bad73480108cb03cb69cdec8898b01790f) file format - [`6d9f229`](https://github.com/Rigellute/spotify-tui/commit/6d9f22912dd7de3364bd612de007bb22983e3d81) Merge branch 'master' of https://github.com/Rigellute/spotify-tui into merge-res - [`93188b0`](https://github.com/Rigellute/spotify-tui/commit/93188b0ad86aca7e9cd13fd8e6b8f36fc3f3edcb) merge res - [`e17b904`](https://github.com/Rigellute/spotify-tui/commit/e17b9046bd9f16c0446384213f64b4e9f8417f1f) Added vis script - [`8cc1299`](https://github.com/Rigellute/spotify-tui/commit/8cc1299aa92146e1cb92e0f67f5e1b1fe7b3fbb1) Satisfy clippy - [`bfd2c46`](https://github.com/Rigellute/spotify-tui/commit/bfd2c46e18599fdfa66be50e259ee1c5a02b8371) Errors (#2) - [`1cc0dbc`](https://github.com/Rigellute/spotify-tui/commit/1cc0dbc235da8e65655cb7415431e3575e6b1356) Merge branch 'master' of https://github.com/AnotherGroupChat/spotify-tui - [`427f037`](https://github.com/Rigellute/spotify-tui/commit/427f0376b7fb66f52c54999f17e835c617bd14ad) Move vis into engine instead of just compiling the ast ### 📊 Changes **9 files changed** (+526 additions, -142 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+29 -2) 📝 `Cargo.toml` (+1 -0) 📝 `src/app.rs` (+56 -0) ➕ `src/error.rs` (+35 -0) 📝 `src/main.rs` (+12 -1) 📝 `src/ui/audio_analysis.rs` (+145 -73) 📝 `src/user_config.rs` (+148 -20) 📝 `src/util.rs` (+46 -46) ➕ `visulizations/keys.rhai` (+54 -0) </details> ### 📄 Description Just wanted to follow up on https://github.com/Rigellute/spotify-tui/issues/613#issuecomment-707580846 This needs a ton of cleaning, just got it to a place where it runs. Notably: - break up audio_analysis - Abstract out some of the rhai evaluation - Allow for more than bar charts - use raw engine over full engine for rhai - Create plugin dir and init with default plugins - change `Result<Thing, String>` -> Result<Thing, VizError>` - standardize some of the variables names etc.. - write documentation Maybe in another PR - Allow for plugin change during run - Allow for plugin reload And then - Allow for basic mode w/o analysis --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>