[PR #612] [MERGED] Update the saved albums cache set when getting an artist #929

New issue

Closed

opened 2026-02-28 14:53:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:53:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/612
Author: @Utagai
Created: 10/10/2020
Status: ✅ Merged
Merged: 10/13/2020
Merged by: @Rigellute

Base: master ← Head: saved-albums-not-marked

📝 Commits (2)

0b64143 Update the saved albums cache set when getting an artist
bab09fe Prefer dispatching an IO event for updating the album cache set

📊 Changes

1 file changed (+13 additions, -4 deletions)

View changed files

📝 src/network.rs (+13 -4)

📄 Description

This closes #611 which I just filed.

Check out the issue for some screenshots. This PR effectively makes the second screenshot in that issue description correct, in that it recognizes the saved albums on that artist.

As mentioned in that issue too, we seemingly do not update the saved tracks set when searching, so I omitted adding that into this patch, but it's easy enough to extend this patch to apply to tracks and make things consistent.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/612 **Author:** [@Utagai](https://github.com/Utagai) **Created:** 10/10/2020 **Status:** ✅ Merged **Merged:** 10/13/2020 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `saved-albums-not-marked` --- ### 📝 Commits (2) - [`0b64143`](https://github.com/Rigellute/spotify-tui/commit/0b641439b913ac7876f3d4b2de566bee8b0f12a2) Update the saved albums cache set when getting an artist - [`bab09fe`](https://github.com/Rigellute/spotify-tui/commit/bab09fefc576eebe04f82a02dcec1bfb87c59f69) Prefer dispatching an IO event for updating the album cache set ### 📊 Changes **1 file changed** (+13 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/network.rs` (+13 -4) </details> ### 📄 Description This closes #611 which I just filed. Check out the issue for some screenshots. This PR effectively makes the second screenshot in that issue description correct, in that it recognizes the saved albums on that artist. As mentioned in that issue too, we seemingly _do not_ update the saved tracks set when searching, so I omitted adding that into this patch, but it's easy enough to extend this patch to apply to tracks and make things consistent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>