[PR #604] [MERGED] Implement next/previous page behavior for the Artists table #922

Closed
opened 2026-02-28 14:53:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/604
Author: @Utagai
Created: 10/4/2020
Status: Merged
Merged: 10/11/2020
Merged by: @Rigellute

Base: masterHead: add-paging-to-artists


📝 Commits (1)

  • 43c0863 Implement next/previous pagination behavior for the artists view

📊 Changes

3 files changed (+58 additions, -0 deletions)

View changed files

📝 src/app.rs (+46 -0)
📝 src/handlers/artists.rs (+2 -0)
📝 src/network.rs (+10 -0)

📄 Description

This closes #603 which I just filed.

I'm new to Rust, so any feedback is welcome!

Lastly, I think pagination behavior may be in want of a re-work. It seems like we're missing pagination for a bunch of views and I imagine their implementations will all share quite a bit in common. I didn't take on the larger task of a big refactor but it may be something we should consider.

Here's a demo gif (ignore color issues, it's my first time trying to use terminalizer to record my terminal).
artists-pagination-demo


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/604 **Author:** [@Utagai](https://github.com/Utagai) **Created:** 10/4/2020 **Status:** ✅ Merged **Merged:** 10/11/2020 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `add-paging-to-artists` --- ### 📝 Commits (1) - [`43c0863`](https://github.com/Rigellute/spotify-tui/commit/43c0863610ef278cc1f7d6588f5ae04089aea68e) Implement next/previous pagination behavior for the artists view ### 📊 Changes **3 files changed** (+58 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/app.rs` (+46 -0) 📝 `src/handlers/artists.rs` (+2 -0) 📝 `src/network.rs` (+10 -0) </details> ### 📄 Description This closes #603 which I just filed. I'm new to Rust, so any feedback is welcome! Lastly, I think pagination behavior may be in want of a re-work. It seems like we're missing pagination for a bunch of views and I imagine their implementations will all share quite a bit in common. I didn't take on the larger task of a big refactor but it may be something we should consider. Here's a demo gif (ignore color issues, it's my first time trying to use `terminalizer` to record my terminal). ![artists-pagination-demo](https://user-images.githubusercontent.com/10730394/95007102-cc62c800-05d9-11eb-9c18-2ef733ad128b.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:53:50 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-tui#922
No description provided.