[PR #585] [MERGED] Show active keybindings in Help #909

New issue

Closed

opened 2026-02-28 14:53:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:53:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/585
Author: @bi1yeu
Created: 9/21/2020
Status: ✅ Merged
Merged: 10/5/2020
Merged by: @Rigellute

Base: master ← Head: show-keybindings-in-help

📝 Commits (6)

6893eed show active keybindings in help menu
bf46412 properly format bare keys as <Keyname>
1082ac8 fix formatting
6ffe4f3 Merge remote-tracking branch 'upstream/master' into show-keybindings-in-help
040327c add new keybindings to help menu
8c8022a fix formatting again

📊 Changes

4 files changed (+266 additions, -86 deletions)

View changed files

📝 src/event/key.rs (+26 -0)
📝 src/main.rs (+1 -1)
📝 src/ui/help.rs (+238 -84)
📝 src/ui/mod.rs (+1 -1)

📄 Description

Closes #572

Makes the Help page display the active keybindings from config rather than the hard-coded defaults.

Functionally tested by putting some keybindings in ~/.config/spotify-tui/config.yml and observing they were displayed on the Help page.

I tried to match the current Help page styling for key strings: <Enter>, <Space>, <Ctrl+x>, etc.

P.S. This is my first time writing Rust, so please let me know if anything isn't idiomatic (or is completely wrong)!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/585 **Author:** [@bi1yeu](https://github.com/bi1yeu) **Created:** 9/21/2020 **Status:** ✅ Merged **Merged:** 10/5/2020 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `show-keybindings-in-help` --- ### 📝 Commits (6) - [`6893eed`](https://github.com/Rigellute/spotify-tui/commit/6893eed8b97a5bdbba8bc342cce07f274f20828b) show active keybindings in help menu - [`bf46412`](https://github.com/Rigellute/spotify-tui/commit/bf46412587cdfbdace51cd31391858e8e4d1ad03) properly format bare keys as `<Keyname>` - [`1082ac8`](https://github.com/Rigellute/spotify-tui/commit/1082ac8159d940abb043801fefed2a8ecb403fc3) fix formatting - [`6ffe4f3`](https://github.com/Rigellute/spotify-tui/commit/6ffe4f3f0afb631dcf38f199d6cbdb5f3fa860a8) Merge remote-tracking branch 'upstream/master' into show-keybindings-in-help - [`040327c`](https://github.com/Rigellute/spotify-tui/commit/040327cb17c2cd23d83fb1024c2ab9bb749fdb3e) add new keybindings to help menu - [`8c8022a`](https://github.com/Rigellute/spotify-tui/commit/8c8022a284a2e6a6d0643ffa9e49578a4182ae46) fix formatting again ### 📊 Changes **4 files changed** (+266 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `src/event/key.rs` (+26 -0) 📝 `src/main.rs` (+1 -1) 📝 `src/ui/help.rs` (+238 -84) 📝 `src/ui/mod.rs` (+1 -1) </details> ### 📄 Description Closes #572 Makes the Help page display the active keybindings from config rather than the hard-coded defaults. Functionally tested by putting some keybindings in `~/.config/spotify-tui/config.yml` and observing they were displayed on the Help page. I tried to match the current Help page styling for key strings: `<Enter>`, `<Space>`, `<Ctrl+x>`, etc. <img width="1280" alt="active keybindings" src="https://user-images.githubusercontent.com/1185129/93737279-99f7aa80-fb97-11ea-8bbd-c210e63fc417.png"> P.S. This is my first time writing Rust, so please let me know if anything isn't idiomatic (or is completely wrong)! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>