mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-26 08:05:57 +03:00
[PR #581] [MERGED] Full Podcast support #906
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#906
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Rigellute/spotify-tui/pull/581
Author: @sputnick1124
Created: 9/19/2020
Status: ✅ Merged
Merged: 10/1/2020
Merged by: @Rigellute
Base:
master← Head:podcast-support-search📝 Commits (10+)
a5e41a9Handle ctrl-h like backspace87cc402Merge branch 'master' of https://github.com/rigellute/spotify-tuidbc749eMerge branch 'master' of https://github.com/rigellute/spotify-tuia49e73eMerge branch 'master' of https://github.com/rigellute/spotify-tuic9e6996Merge branch 'master' of https://github.com/rigellute/spotify-tuibe960c7Merge branch 'master' of https://github.com/sputnick1124/spotify-tui1b0a1feMerge branch 'master' of https://github.com/rigellute/spotify-tui01ed400Stub out podcast search resultsbafc623Draw podcast search resultscc25aa5Draw rough podcast episode table📊 Changes
9 files changed (+403 additions, -14 deletions)
View changed files
📝
src/app.rs(+26 -0)📝
src/handlers/common_key_events.rs(+6 -0)➕
src/handlers/episode_table.rs(+96 -0)📝
src/handlers/mod.rs(+4 -0)📝
src/handlers/search_results.rs(+77 -4)📝
src/main.rs(+2 -1)📝
src/network.rs(+41 -1)📝
src/ui/help.rs(+5 -0)📝
src/ui/mod.rs(+146 -8)📄 Description
Fully functional as is, but still missing some features that I think should be implemented before this is considered complete. Here's the status on this thus far. Open to cutting this PR here and opening new PRs for remaining tasks. Otherwise, I plan on getting rid of the draft status when the following are complete:
Library podcast viewDisplay episode description with new hotkey (CTRL-]?)*
Paged episode results/ filter by FullyPlayed statusFollow/Unfollow podcasts (from episode table, show search view, and playbar context)UPDATE: This PR is getting to be pretty big already. I think the other features can be implemented piecemeal in smaller PRs to follow. Some of these are fairly simple and could be good opportunities for newcomers to get their feet wet in the project.
Note that the above GIF shows the progress bar from https://github.com/Rigellute/spotify-tui/pull/563
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.