starred/spotify-tui
1
0
Fork 0
mirror of https://github.com/Rigellute/spotify-tui.git synced 2026-04-27 00:25:53 +03:00
Code Issues 306 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #175] after upgrade cursor in search bar not aligned vertically correctly #90

New issue
Closed
opened 2026-02-28 14:46:57 +03:00 by kerem · 5 comments
kerem commented 2026-02-28 14:46:57 +03:00
Owner
Copy link

Originally created by @stevensonmt on GitHub (Nov 30, 2019).
Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/175

Updated to latest release with cargo. After update the cursor in the search box is vertically centered on the bottom of the search box border while text appears centered vertically in the search box. See screenshot:
image

Originally created by @stevensonmt on GitHub (Nov 30, 2019). Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/175 Updated to latest release with cargo. After update the cursor in the search box is vertically centered on the bottom of the search box border while text appears centered vertically in the search box. See screenshot: ![image](https://user-images.githubusercontent.com/8891908/69906347-fffc1280-1376-11ea-93cc-b0a3962ade16.png)
kerem closed this issue 2026-02-28 14:46:57 +03:00
kerem commented 2026-02-28 14:46:58 +03:00
Author
Owner
Copy link

@Rigellute commented on GitHub (Dec 2, 2019):

Hmm... strange. Looks okay to me.
image

Not yet sure which commit might have messed with cursor position in your case.

<!-- gh-comment-id:560312401 --> @Rigellute commented on GitHub (Dec 2, 2019): Hmm... strange. Looks okay to me. <img width="843" alt="image" src="https://user-images.githubusercontent.com/12150276/69947962-a74b8780-14e6-11ea-854c-05ad7d394f87.png"> Not yet sure which commit might have messed with cursor position in your case.
kerem commented 2026-02-28 14:46:58 +03:00
Author
Owner
Copy link

@ghost commented on GitHub (Dec 2, 2019):

I'm not sure what caused this behavior but it seems to occur depending on terminal size.

51 lines in the window:
spt_01

43 lines in the window:
spt_02

<!-- gh-comment-id:560335582 --> @ghost commented on GitHub (Dec 2, 2019): I'm not sure what caused this behavior but it seems to occur depending on terminal size. 51 lines in the window: ![spt_01](https://user-images.githubusercontent.com/54503126/69951921-87917f00-1539-11ea-8635-7a3e9d50599c.png) 43 lines in the window: ![spt_02](https://user-images.githubusercontent.com/54503126/69951932-8bbd9c80-1539-11ea-83b1-d23f4c47ea14.png)
kerem commented 2026-02-28 14:46:58 +03:00
Author
Owner
Copy link

@ghost commented on GitHub (Dec 2, 2019):

I found that the margin of main layout is set to 1 or 0 depending on terminal height (line 142 in src/ui/mod.rs) and this seems to cause the problem. To fix it, fix margin size to 0 or 1 regardless of terminal height or change cursor position when terminal height is lower than 45. If anyone does not fix it, I will do.

<!-- gh-comment-id:560361652 --> @ghost commented on GitHub (Dec 2, 2019): I found that the margin of main layout is set to 1 or 0 depending on terminal height (line 142 in `src/ui/mod.rs`) and this seems to cause the problem. To fix it, fix margin size to 0 or 1 regardless of terminal height or change cursor position when terminal height is lower than 45. If anyone does not fix it, I will do.
kerem commented 2026-02-28 14:46:58 +03:00
Author
Owner
Copy link

@stevensonmt commented on GitHub (Dec 2, 2019):

Can confirm that larger terminal height fixes the cursor alignment. As for which commit, I don't know but I've got version 0.10.0 - 2019-11-30 showing up on the initial screen.

<!-- gh-comment-id:560451240 --> @stevensonmt commented on GitHub (Dec 2, 2019): Can confirm that larger terminal height fixes the cursor alignment. As for which commit, I don't know but I've got version 0.10.0 - 2019-11-30 showing up on the initial screen.
kerem commented 2026-02-28 14:46:58 +03:00
Author
Owner
Copy link

@Rigellute commented on GitHub (Dec 2, 2019):

@echoSayonara ah yes of course!! I will PR a fix a bit later today

<!-- gh-comment-id:560467331 --> @Rigellute commented on GitHub (Dec 2, 2019): @echoSayonara ah yes of course!! I will PR a fix a bit later today
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/cargo/bumpalo-3.12.0
dependabot/cargo/serde-1.0.152
dependabot/cargo/serde_json-1.0.91
dependabot/cargo/anyhow-1.0.68
dependabot/cargo/smallvec-1.8.0
dependabot/cargo/futures-task-0.3.21
dependabot/cargo/futures-util-0.3.21
dependabot/cargo/lock_api-0.4.6
dependabot/cargo/hyper-0.13.10
dependabot/cargo/socket2-0.3.19
dependabot/cargo/nix-0.20.2
dependabot/cargo/crossterm-0.22.1
dependabot/cargo/dirs-4.0.0
dependabot/add-v2-config-file
async-await
async-await-tokio-1
echoSayonara-fork-modify-artist-window
SethGower-notifications
revert-133-page-scroll-rigel
revert-133-page-scroll
auto-redirect-code
jump-to-currently-playing-artist
move-device-cache-to-config
v0.25.0
v0.24.0
v0.23.0
v0.22.0
v0.21.0
v0.20.0
v0.19.0
v0.18.0
v0.17.1
v0.17.0
v0.16.0
v0.15.0
v0.14.0
v0.13.0
v0.12.0
v0.11.0
v0.10.0
v0.9.0
v0.8.0
v0.7.5
v0.7.4
v0.7.3
v0.7.2
v0.7.1
v0.7.0
v0.6.2
v0.6.1
v0.6.0
v0.5.0
v0.4.0
0.3.0
v0.3.0
v0.3-alpha
v0.2-alpha
0.1
Labels
Clear labels   
bug

   
enhancement

   
good first issue

   
help wanted

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
enhancement
good first issue
help wanted
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-tui#90
No description provided.