[PR #531] [CLOSED] Load playlist listing greedily #878

New issue

Closed

opened 2026-02-28 14:53:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:53:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/531
Author: @jackkinsey
Created: 7/21/2020
Status: ❌ Closed

Base: master ← Head: many-playlists

📝 Commits (1)

4155e9e Continue loading playlists until all are loaded

📊 Changes

1 file changed (+26 additions, -2 deletions)

View changed files

📝 src/network.rs (+26 -2)

📄 Description

Fixes #116.

This change defies the pagination model the rest of the application seems to be using, requesting pages of playlists until all playlists have been loaded. (It's also slightly hacky in doing so.)

I totally understand if you don't want to go this route with the app, but I figured I might as well show up with some working code to get the conversation started. (Obligatory note about being a Rust beginner/apologies if my code isn't idiomatic.)

Thanks for making this! It's super cool, I look forward to using it more.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/531 **Author:** [@jackkinsey](https://github.com/jackkinsey) **Created:** 7/21/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `many-playlists` --- ### 📝 Commits (1) - [`4155e9e`](https://github.com/Rigellute/spotify-tui/commit/4155e9eb511d2abcde43136be75ba74b158d50fb) Continue loading playlists until all are loaded ### 📊 Changes **1 file changed** (+26 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/network.rs` (+26 -2) </details> ### 📄 Description Fixes #116. This change defies the pagination model the rest of the application seems to be using, requesting pages of playlists until all playlists have been loaded. (It's also slightly hacky in doing so.) I totally understand if you don't want to go this route with the app, but I figured I might as well show up with some working code to get the conversation started. (Obligatory note about being a Rust beginner/apologies if my code isn't idiomatic.) Thanks for making this! It's super cool, I look forward to using it more. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>