mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-25 23:55:53 +03:00
[PR #502] [MERGED] Simple change of layout #860
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#860
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Rigellute/spotify-tui/pull/502
Author: @mucinoab
Created: 6/20/2020
Status: ✅ Merged
Merged: 10/21/2020
Merged by: @Rigellute
Base:
master← Head:master📝 Commits (4)
be350d5Change of layout. Constraints of size in fn draw_input_and_help_box changed from ".constraints([Constraint::Percentage(90), Constraint::Percentage(10)].as_ref())" to ".constraints([Constraint::Percentage(65), Constraint::Percentage(35)].as_ref())" to better suit the smaller space. fn draw_input_and_help_box moved to fn_draw_user_blockdd33d03Add responsiveness to new layout changec98d661Merge pull request #1 from OrangeFran/master7185a2cFix formatting.📊 Changes
2 files changed (+72 additions, -30 deletions)
View changed files
📝
src/ui/mod.rs(+71 -30)📝
src/ui/util.rs(+1 -0)📄 Description
draw_input_and_help_boxmoved todraw_user_blockso the search and help bar is reduced and the main panel is adjusted to fill that space. The constraints of size of both functions were tweaked as well to better fit the new layout.I feel this new layout does a better job at taking advantage of space as the strings we search are usually not that long and after some use of the client the help bar becomes more or less irrelevant.
Here some screenshots
Fullscreen in a 1080p monitor

Halfscreen in a 1080p monitor

Current layout for comparison

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.