[PR #435] [MERGED] Temp fix audio_analysis feature #818

New issue

Closed

opened 2026-02-28 14:53:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:53:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/435
Author: @Rigellute
Created: 5/4/2020
Status: ✅ Merged
Merged: 5/4/2020
Merged by: @Rigellute

Base: master ← Head: fix-audio-analysis

📝 Commits (1)

e60dfbe Temp fix audio_analysis feature

📊 Changes

3 files changed (+14 additions, -11 deletions)

View changed files

📝 Cargo.lock (+1 -2)
📝 Cargo.toml (+1 -1)
📝 src/ui/audio_analysis.rs (+12 -8)

📄 Description

The Spotify endpoint for audio analysis has recently changed - some fields are now undefined.

There is no official documentation of this, which is why I've had to use the heavy handed approach of making all
audio analysis properties optional (fix made in rspotify).

This fix won't be accepted upstream (see link above), so I've had to use my fork of rspotify to fix this in the meantime.

Hopefully a more permanent fix will follow.

Closes #416

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/435 **Author:** [@Rigellute](https://github.com/Rigellute) **Created:** 5/4/2020 **Status:** ✅ Merged **Merged:** 5/4/2020 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `fix-audio-analysis` --- ### 📝 Commits (1) - [`e60dfbe`](https://github.com/Rigellute/spotify-tui/commit/e60dfbed15b7110e0346ec45fed9ed8f608eac1b) Temp fix audio_analysis feature ### 📊 Changes **3 files changed** (+14 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -2) 📝 `Cargo.toml` (+1 -1) 📝 `src/ui/audio_analysis.rs` (+12 -8) </details> ### 📄 Description The Spotify endpoint for audio analysis has recently changed - some fields are now undefined. There is no official documentation of this, which is why I've had to use the heavy handed approach of making all audio analysis properties optional (fix made in [rspotify](https://github.com/ramsayleung/rspotify/pull/94)). This fix won't be accepted upstream (see link above), so I've had to use my fork of rspotify to fix this in the meantime. Hopefully a more permanent fix will follow. Closes #416 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>