mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-26 16:15:55 +03:00
[PR #404] [CLOSED] Bump tui from 0.8.0 to 0.9.1 #803
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#803
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Rigellute/spotify-tui/pull/404
Author: @fdehau
Created: 4/16/2020
Status: ❌ Closed
Base:
master← Head:tui📝 Commits (1)
39788b8Bump tui from 0.8.0 to 0.9.1📊 Changes
4 files changed (+129 additions, -153 deletions)
View changed files
📝
Cargo.lock(+16 -33)📝
Cargo.toml(+3 -3)📝
src/ui/audio_analysis.rs(+29 -31)📝
src/ui/mod.rs(+81 -86)📄 Description
Replace all
Widget.rendercalls byFrame::render_widgetand refactorto remove newly introduced lifetimes issues.
I've kept the diff to a minimum. In particular, I'm not taking advantage of the new
ListStateassociated to theListwidget that would allow a better scrolling experience because it is likely that it would require changes in theAppstruct and I'm not familiar enough with the code to do that kind of refactor.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.