[PR #184] [MERGED] Remove focus on input when jumping back #657

Closed
opened 2026-02-28 14:50:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/184
Author: @nilsrauch
Created: 12/2/2019
Status: Merged
Merged: 12/23/2019
Merged by: @Rigellute

Base: masterHead: no-input-focus-on-back


📝 Commits (1)

  • bd40482 Remove focus on input when jumping back

📊 Changes

1 file changed (+8 additions, -2 deletions)

View changed files

📝 src/main.rs (+8 -2)

📄 Description

This is fixing #174

First of all I wanted to say that I'm pretty new to Rust so if you notice anything and have tips for me please feel free to share them with me :)

Also I realized that if the first action is to use the input field (thus the second route in the navigation_stack being a route with the id Search) the Home route will not be shown on navigating back because the second route will be popped in the match I've added and the is_none() check will break after...

I didn't know how to prevent this effectively without slaughtering the code. So any ideas would be really appreciated.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/184 **Author:** [@nilsrauch](https://github.com/nilsrauch) **Created:** 12/2/2019 **Status:** ✅ Merged **Merged:** 12/23/2019 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `no-input-focus-on-back` --- ### 📝 Commits (1) - [`bd40482`](https://github.com/Rigellute/spotify-tui/commit/bd40482cea6efec2cf29672f98c45f1455a2dd30) Remove focus on input when jumping back ### 📊 Changes **1 file changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/main.rs` (+8 -2) </details> ### 📄 Description This is fixing #174 First of all I wanted to say that I'm pretty new to Rust so if you notice anything and have tips for me please feel free to share them with me :) Also I realized that if the first action is to use the input field (thus the second route in the `navigation_stack` being a route with the id `Search`) the `Home` route will not be shown on navigating back because the second route will be popped in the match I've added and the `is_none()` check will break after... I didn't know how to prevent this effectively without slaughtering the code. So any ideas would be really appreciated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:50:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-tui#657
No description provided.