[PR #166] [MERGED] Adjust volume controls behaviour #648

New issue

Closed

opened 2026-02-28 14:50:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:50:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/166
Author: @gpawlik
Created: 11/25/2019
Status: ✅ Merged
Merged: 11/26/2019
Merged by: @Rigellute

Base: master ← Head: volume-adjust

📝 Commits (1)

06c0ed5 Adjust volume controls

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 src/app.rs (+0 -1)

📄 Description

Description of the issue

The volume control does not work as intended, if + and - are pressed in a moderate pace the value updates every second press, and after some time it starts to get even more messy.

Solution to the issue

I have removed get_current_playback call after the successful volume change. In this context I think it is not necessary to poll for the playback data, but maybe I am missing something, would you be able to confirm it @Rigellute ?

Before/After screenshots 📷

Before	After

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/166 **Author:** [@gpawlik](https://github.com/gpawlik) **Created:** 11/25/2019 **Status:** ✅ Merged **Merged:** 11/26/2019 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `volume-adjust` --- ### 📝 Commits (1) - [`06c0ed5`](https://github.com/Rigellute/spotify-tui/commit/06c0ed5e4805a329393ce5a95c971f05d64a9b4a) Adjust volume controls ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/app.rs` (+0 -1) </details> ### 📄 Description ### Description of the issue The volume control does not work as intended, if `+` and `-` are pressed in a moderate pace the value updates every second press, and after some time it starts to get even more messy. ### Solution to the issue I have removed `get_current_playback` call after the successful volume change. In this context I think it is not necessary to poll for the playback data, but maybe I am missing something, would you be able to confirm it @Rigellute ? ### Before/After screenshots 📷 | Before | After | | -------------------- | ------------------- | | ![bbb](https://user-images.githubusercontent.com/6296883/69582912-89a38d00-0fd1-11ea-9347-ddbe4863396e.gif) | ![aaa](https://user-images.githubusercontent.com/6296883/69582881-755f9000-0fd1-11ea-8288-282b3e261bbf.gif) | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>