[PR #162] [MERGED] Fix columns width in Saved Albums #644

New issue

Closed

opened 2026-02-28 14:50:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:50:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/162
Author: @gpawlik
Created: 11/24/2019
Status: ✅ Merged
Merged: 11/25/2019
Merged by: @Rigellute

Base: master ← Head: fix-columns-width

📝 Commits (1)

55edaa4 Fix columns width in Saved Albums

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/ui/mod.rs (+1 -1)

📄 Description

Description of the issue

Massive PR! 😄

The Release Date column was missing in the Albums table, which was caused by width exceeding the total available space.

The same happens for Length in Recently Played Tracks table, because of Liked column of fixed width 2. I couldn't decide whether change it to a percentage calculated value or just subtract it from the next column (eg. width: get_percentage_width(layout_chunk.width, 2.0 / 5.0) - 2). What do you think @Rigellute ?

Before	After

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/162 **Author:** [@gpawlik](https://github.com/gpawlik) **Created:** 11/24/2019 **Status:** ✅ Merged **Merged:** 11/25/2019 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `fix-columns-width` --- ### 📝 Commits (1) - [`55edaa4`](https://github.com/Rigellute/spotify-tui/commit/55edaa4f5a9b58e1102df46da381d554052c1d1f) Fix columns width in Saved Albums ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/ui/mod.rs` (+1 -1) </details> ### 📄 Description ### Description of the issue Massive PR! 😄 The `Release Date` column was missing in the `Albums` table, which was caused by width exceeding the total available space. The same happens for `Length` in `Recently Played Tracks` table, because of `Liked` column of fixed width `2`. I couldn't decide whether change it to a percentage calculated value or just subtract it from the next column (eg. `width: get_percentage_width(layout_chunk.width, 2.0 / 5.0) - 2`). What do you think @Rigellute ? | Before | After | | -------------------- | ------------------- | | <img width="600" alt="Screenshot 2019-11-24 at 21 16 03" src="https://user-images.githubusercontent.com/6296883/69502004-61009200-0f02-11ea-86da-33d964db7d6d.png"> | <img width="600" alt="Screenshot 2019-11-24 at 21 15 32" src="https://user-images.githubusercontent.com/6296883/69502001-5645fd00-0f02-11ea-9f3b-cfab929211b7.png"> | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>