[PR #154] [MERGED] Adjust search limits #637

New issue

Closed

opened 2026-02-28 14:50:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:50:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/154
Author: @ghost
Created: 11/18/2019
Status: ✅ Merged
Merged: 11/18/2019
Merged by: @Rigellute

Base: master ← Head: search-result

📝 Commits (1)

aaf94c5 Adjust serach limits

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 src/main.rs (+5 -3)

📄 Description

When terminal size is changed, some contents are not showed in the table. Additionally, regardless terminal size, search returns only 4 contents.

Here, I tried to fix these problem, i adjust search limits depending on the terminal size. However, parameters I used here are not led deductively but empirically.

If you know the way to get height of each block, preferable implementation can be available. For me, my implementation is not smart and if you have any idea, please tell me it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/154 **Author:** [@ghost](https://github.com/ghost) **Created:** 11/18/2019 **Status:** ✅ Merged **Merged:** 11/18/2019 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `search-result` --- ### 📝 Commits (1) - [`aaf94c5`](https://github.com/Rigellute/spotify-tui/commit/aaf94c5faff8cd11352c830268cb4ba232d9e8f3) Adjust serach limits ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/main.rs` (+5 -3) </details> ### 📄 Description When terminal size is changed, some contents are not showed in the table. Additionally, regardless terminal size, search returns only 4 contents. Here, I tried to fix these problem, i adjust search limits depending on the terminal size. However, parameters I used here are not led deductively but empirically. If you know the way to get height of each block, preferable implementation can be available. For me, my implementation is not smart and if you have any idea, please tell me it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>