[PR #142] [CLOSED] Added config module 'visuals' and added window margin configuration #630

Closed
opened 2026-02-28 14:50:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/142
Author: @jfaltis
Created: 11/6/2019
Status: Closed

Base: masterHead: config-visuals-margin


📝 Commits (2)

  • a1ba7cb added config module 'visuals' and added window margin configuration
  • 3938aab Rustfmt

📊 Changes

3 files changed (+17 additions, -1 deletions)

View changed files

📝 README.md (+3 -0)
📝 src/ui/mod.rs (+1 -1)
📝 src/user_config.rs (+13 -0)

📄 Description

This PR references https://github.com/Rigellute/spotify-tui/issues/138. I added the functionality to configure through window margin in the configuration file.

E.g. to remove the margin add to ~/spotify-tui/config.yaml

visuals:
    margin: 0

If the margin is unset its default value is 1 which I think looks better than the previous default of 2 if you want to keep the margin. @Rigellute what default margin do you prefer?


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/142 **Author:** [@jfaltis](https://github.com/jfaltis) **Created:** 11/6/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `config-visuals-margin` --- ### 📝 Commits (2) - [`a1ba7cb`](https://github.com/Rigellute/spotify-tui/commit/a1ba7cb4ae0612ffb453de3e7e18810387a8fdb8) added config module 'visuals' and added window margin configuration - [`3938aab`](https://github.com/Rigellute/spotify-tui/commit/3938aab27066f226e9a07dc6a2c8a7f32ad2603a) Rustfmt ### 📊 Changes **3 files changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+3 -0) 📝 `src/ui/mod.rs` (+1 -1) 📝 `src/user_config.rs` (+13 -0) </details> ### 📄 Description This PR references https://github.com/Rigellute/spotify-tui/issues/138. I added the functionality to configure through window margin in the configuration file. E.g. to remove the margin add to `~/spotify-tui/config.yaml` ``` visuals: margin: 0 ``` If the margin is unset its default value is 1 which I think looks better than the previous default of 2 if you want to keep the margin. @Rigellute what default margin do you prefer? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:50:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-tui#630
No description provided.