[PR #137] [CLOSED] Fix paging in the Playlist #627

Closed
opened 2026-02-28 14:50:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/137
Author: @ghost
Created: 11/5/2019
Status: Closed

Base: revert-133-page-scroll-rigelHead: revert-page-scroll


📝 Commits (2)

  • 646af00 Fix paging in the Playlist
  • e620e69 Use if let instead of match

📊 Changes

1 file changed (+25 additions, -6 deletions)

View changed files

📝 src/main.rs (+25 -6)

📄 Description

Fix the problem that a wrong track is played after open some playlists. https://github.com/Rigellute/spotify-tui/pull/133#issuecomment-549640154

Reset playlist_tracks when go back from the track table of a playlist and it fix the problem.

Paging in the playlist does not have problems that you pointed out and I found. Scrolling down/up works well and a correct track is played when i press enter in the track table of a playlist.

I commented out some codes that does not go well (line 249-256 in main.rs). Although it goes not work but it seems better to me. I do not know why those codes does work. Please check it.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/137 **Author:** [@ghost](https://github.com/ghost) **Created:** 11/5/2019 **Status:** ❌ Closed **Base:** `revert-133-page-scroll-rigel` ← **Head:** `revert-page-scroll` --- ### 📝 Commits (2) - [`646af00`](https://github.com/Rigellute/spotify-tui/commit/646af0030e40f78159f4f4bb3f76b8cd5c29fc3b) Fix paging in the Playlist - [`e620e69`](https://github.com/Rigellute/spotify-tui/commit/e620e69909cbc37e0c569bb7e4212f3c35f9e2f8) Use if let instead of match ### 📊 Changes **1 file changed** (+25 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/main.rs` (+25 -6) </details> ### 📄 Description Fix the problem that a wrong track is played after open some playlists. https://github.com/Rigellute/spotify-tui/pull/133#issuecomment-549640154 Reset `playlist_tracks` when go back from the track table of a playlist and it fix the problem. Paging in the playlist does not have problems that you pointed out and I found. Scrolling down/up works well and a correct track is played when i press enter in the track table of a playlist. I commented out some codes that does not go well (line 249-256 in `main.rs`). Although it goes not work but it seems better to me. I do not know why those codes does work. Please check it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:50:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-tui#627
No description provided.