[PR #128] [MERGED] Add support for scrolling up/down when album list is active #620

New issue

Closed

opened 2026-02-28 14:50:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:50:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/128
Author: @ghost
Created: 11/3/2019
Status: ✅ Merged
Merged: 11/3/2019
Merged by: @Rigellute

Base: master ← Head: scroll-album-list

📝 Commits (2)

d6831d3 Add support for scrolling up/down when album list is active
14b093d use !is_empty instead of len() > 0

📊 Changes

3 files changed (+43 additions, -11 deletions)

View changed files

📝 src/app.rs (+39 -0)
📝 src/handlers/album_list.rs (+2 -0)
📝 src/handlers/library.rs (+2 -11)

📄 Description

This PR is related to #11

ctrl+d/u should scroll through pages but this has been implemented in "Liked Songs" view only. In this PR, I tried to implement scrolling down/up in the "Albums" view.

need to confirm:
In src/app.rs, I added three methods (get_current_user_saved_albums, get_current_user_saved_albums_next, and get_current_user_saved_albums_previous) for App. These methods are imitation of **saved_tracks** methods. Although push_navigation_stack is called in get_current_user_saved_tracks, I did NOT call push_navigation_stack in get_current_user_saved_albums. If push_navigation_stack is called after each page scrolling, same contents are pushed into the stack. Scrolling pages several time, q key (go back) seems foul-up. This behavior seems a bug for me so I did not call push_navigation_stack in get_current_user_saved_albums.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/128 **Author:** [@ghost](https://github.com/ghost) **Created:** 11/3/2019 **Status:** ✅ Merged **Merged:** 11/3/2019 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `scroll-album-list` --- ### 📝 Commits (2) - [`d6831d3`](https://github.com/Rigellute/spotify-tui/commit/d6831d39a2e45ae6c740d9d7c915025a05b51974) Add support for scrolling up/down when album list is active - [`14b093d`](https://github.com/Rigellute/spotify-tui/commit/14b093d4ac50c789ca759ad992bb7c8404860677) use `!is_empty` instead of `len() > 0` ### 📊 Changes **3 files changed** (+43 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/app.rs` (+39 -0) 📝 `src/handlers/album_list.rs` (+2 -0) 📝 `src/handlers/library.rs` (+2 -11) </details> ### 📄 Description This PR is related to #11 `ctrl+d/u` should scroll through pages but this has been implemented in "Liked Songs" view only. In this PR, I tried to implement scrolling down/up in the "Albums" view. need to confirm: In `src/app.rs`, I added three methods (`get_current_user_saved_albums`, `get_current_user_saved_albums_next`, and `get_current_user_saved_albums_previous`) for `App`. These methods are imitation of `**saved_tracks**` methods. Although `push_navigation_stack` is called in `get_current_user_saved_tracks`, I did **NOT** call `push_navigation_stack` in `get_current_user_saved_albums`. If `push_navigation_stack` is called after each page scrolling, same contents are pushed into the stack. Scrolling pages several time, q key (go back) seems foul-up. This behavior seems a bug for me so I did not call `push_navigation_stack` in `get_current_user_saved_albums`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>