mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-26 16:15:55 +03:00
[PR #111] [MERGED] Show backtrace on app crash #614
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#614
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Rigellute/spotify-tui/pull/111
Author: @jfaltis
Created: 10/25/2019
Status: ✅ Merged
Merged: 10/27/2019
Merged by: @Rigellute
Base:
master← Head:show-backtrace📝 Commits (2)
03b67e0show backtrace on crash070c6a2rustfmt📊 Changes
3 files changed (+40 additions, -7 deletions)
View changed files
📝
Cargo.lock(+8 -7)📝
Cargo.toml(+1 -0)📝
src/main.rs(+31 -0)📄 Description
This PR enables the output of the backtrace to the terminal when the app panics. This feature is currently only enabled in Debug and also ignores the
RUST_BACKTRACEenvironment variable. It uses the workaround suggested here fdehau/tui-rs#177.Unfortunately there is still an issue with the cursor placement after the crash where it is placed into the stacktrace output if the app was not run from the last line in terminal. Demonstration:
Cursor not at bottom before app is started:

Cursor at bottom before app is started (expected behaviour):

I couldn't figure out a solution yet but I think this could be fixed in a later PR because this is a valuable addition to track down the reason for crashes. This would improve situations like these https://github.com/Rigellute/spotify-tui/issues/102.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.