[PR #19] [MERGED] Add Ctrl-r to cycle repeat mode; fix duplicate albums #568

Closed
opened 2026-02-28 14:50:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/19
Author: @wrenby
Created: 10/8/2019
Status: Merged
Merged: 10/8/2019
Merged by: @Rigellute

Base: masterHead: master


📝 Commits (3)

  • 7e011dc Add Ctrl-r to cycle repeat mode
  • c8a4c18 Fix duplicate albums in artist discographies
  • fca230c cargo fmt --all

📊 Changes

7 files changed (+53 additions, -14 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 README.md (+2 -2)
📝 src/app.rs (+25 -1)
📝 src/handlers/input.rs (+9 -8)
📝 src/main.rs (+3 -0)
📝 src/ui/help.rs (+2 -1)
📝 src/ui/mod.rs (+9 -2)

📄 Description

Included a keybind for repeat modes, which cycles through Off -> All -> Track -> Off as in the Electron client. Interface has a small visual update to show the repeat status next to the shuffle status, seen here. The keybind inherits from shuffle (both ctrl+first letter) which seems consistent to me, but feel free to change it if you see fit.

Also closes #17, which was caused by the client not choosing between different versions of the same album available to disjoint sets of countries. It's not a permanent fix though, as it just follows the example set in input.rs by always requesting the UK versions. It is a little more future-proof in that both now make requests according to a new App::country field, but it's still essentially hard-coded. New search results for queen seen here.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/19 **Author:** [@wrenby](https://github.com/wrenby) **Created:** 10/8/2019 **Status:** ✅ Merged **Merged:** 10/8/2019 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`7e011dc`](https://github.com/Rigellute/spotify-tui/commit/7e011dc69ef71803576dd6a4a4d18e234401f946) Add Ctrl-r to cycle repeat mode - [`c8a4c18`](https://github.com/Rigellute/spotify-tui/commit/c8a4c1872245b69a666376bce599441a72266376) Fix duplicate albums in artist discographies - [`fca230c`](https://github.com/Rigellute/spotify-tui/commit/fca230c20738f73d1494a4564aa1c8c84591351e) cargo fmt --all ### 📊 Changes **7 files changed** (+53 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `README.md` (+2 -2) 📝 `src/app.rs` (+25 -1) 📝 `src/handlers/input.rs` (+9 -8) 📝 `src/main.rs` (+3 -0) 📝 `src/ui/help.rs` (+2 -1) 📝 `src/ui/mod.rs` (+9 -2) </details> ### 📄 Description Included a keybind for repeat modes, which cycles through Off -> All -> Track -> Off as in the Electron client. Interface has a small visual update to show the repeat status next to the shuffle status, seen [here](https://i.imgur.com/MYKgbRN.png). The keybind inherits from shuffle (both ctrl+first letter) which seems consistent to me, but feel free to change it if you see fit. Also closes #17, which was caused by the client not choosing between different versions of the same album available to disjoint sets of countries. It's not a permanent fix though, as it just follows the example set in `input.rs` by always requesting the UK versions. It is a little more future-proof in that both now make requests according to a new `App::country` field, but it's still essentially hard-coded. New search results for queen seen [here](https://imgur.com/HC5Bb7X.png). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:50:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-tui#568
No description provided.