mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-26 08:05:57 +03:00
[PR #19] [MERGED] Add Ctrl-r to cycle repeat mode; fix duplicate albums #568
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#568
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Rigellute/spotify-tui/pull/19
Author: @wrenby
Created: 10/8/2019
Status: ✅ Merged
Merged: 10/8/2019
Merged by: @Rigellute
Base:
master← Head:master📝 Commits (3)
7e011dcAdd Ctrl-r to cycle repeat modec8a4c18Fix duplicate albums in artist discographiesfca230ccargo fmt --all📊 Changes
7 files changed (+53 additions, -14 deletions)
View changed files
📝
CHANGELOG.md(+3 -0)📝
README.md(+2 -2)📝
src/app.rs(+25 -1)📝
src/handlers/input.rs(+9 -8)📝
src/main.rs(+3 -0)📝
src/ui/help.rs(+2 -1)📝
src/ui/mod.rs(+9 -2)📄 Description
Included a keybind for repeat modes, which cycles through Off -> All -> Track -> Off as in the Electron client. Interface has a small visual update to show the repeat status next to the shuffle status, seen here. The keybind inherits from shuffle (both ctrl+first letter) which seems consistent to me, but feel free to change it if you see fit.
Also closes #17, which was caused by the client not choosing between different versions of the same album available to disjoint sets of countries. It's not a permanent fix though, as it just follows the example set in
input.rsby always requesting the UK versions. It is a little more future-proof in that both now make requests according to a newApp::countryfield, but it's still essentially hard-coded. New search results for queen seen here.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.