mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-26 16:15:55 +03:00
[GH-ISSUE #1025] No longer compiles (stable, beta and nightly) #454
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#454
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mucinoab on GitHub (Sep 24, 2022).
Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/1025
I think is due the the changes in the memory layout of
SocketAddrV4( Rust-1.64, compatibility-notes).Updating some of our dependencies should fix it.
❯ rustc --version --verbose@siris commented on GitHub (Nov 5, 2022):
I have confirmed this is also impacting spotify-tui compilations with Rust 1.65.0 (as expected) that was just released:
This fix is quite simple: the
socket2crate just needs to be updated:Once that is done I have confirmed
cargo buildwork fine the latest HEAD commit of spotify-tui:To further confirm running a
cargo install --path .on the latest HEAD commit also works:A quick PR with this
Cargo.lockupdate along with a new patch release should fix this fully for Rust 1.64.0 and beyond.@siris commented on GitHub (Nov 5, 2022):
@Rigellute this is a pretty critical issue as compilations of spotify-tui are completely broken on Rust 1.64.0 and beyond. This breaks any Linux distro or user trying to compile it as part of package management systems or directly from git.
I have tested and verified the fix above and it looks like an automated Cargo.lock PR #990 already is opened with the required fix.
When possible can that PR be merged and a new patch Crate version be released of spotify-tui (v0.25.1) to resolve this?
@siris commented on GitHub (Nov 5, 2022):
Reference Funtoo Linux Bug tracking this: https://bugs.funtoo.org/browse/FL-10687
@siris commented on GitHub (Nov 21, 2022):
@Rigellute bump on this issue. Is there any possibility of someone reviewing PR #990, getting it merged and doing a quick patch version release of
spotify-tuiso it can successfully compile with Rust 1.64.0 and beyond?