[GH-ISSUE #887] Progress bar "overlapping" track length #378

Open
opened 2026-02-28 14:48:47 +03:00 by kerem · 3 comments
Owner

Originally created by @MCT32 on GitHub (Sep 17, 2021).
Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/887

I've noticed since I've updated the track length indicator no longer changes its color when intercepting the progress bar. I used the word overlapping in the title to try to explain it.
image

Originally created by @MCT32 on GitHub (Sep 17, 2021). Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/887 I've noticed since I've updated the track length indicator no longer changes its color when intercepting the progress bar. I used the word overlapping in the title to try to explain it. ![image](https://user-images.githubusercontent.com/32090502/133704597-e55e754e-4f6f-48e0-894a-3b5258788811.png)
Author
Owner

@Takheer commented on GitHub (Sep 17, 2021):

I also have this issue after pausing and resuming a track:
Screenshot 2021-09-17 at 09 37 41

<!-- gh-comment-id:921539959 --> @Takheer commented on GitHub (Sep 17, 2021): I also have this issue after pausing and resuming a track: <img width="1229" alt="Screenshot 2021-09-17 at 09 37 41" src="https://user-images.githubusercontent.com/11667674/133736456-4c476d2a-e391-4958-9e6a-5a42ba635b9a.png">
Author
Owner

@sputnick1124 commented on GitHub (Oct 3, 2021):

I'm seeing this as well. It appears that this has occurred due to an upgrade in the version of tui-rs from version 0.14.0 -> 0.16.0 (github.com/Rigellute/spotify-tui@1ef37e7551). I just tested downgrading back to 0.14.0 and the text is properly inverted when overtaken by the gauge bar.

I think we ought to open an issue in tui-rs about this (if one does not already exist) and then maybe roll back the version until it gets fixed, unless we need 0.16.0 for some feature.

<!-- gh-comment-id:932851149 --> @sputnick1124 commented on GitHub (Oct 3, 2021): I'm seeing this as well. It appears that this has occurred due to an upgrade in the version of [tui-rs](https://github.com/fdehau/tui-rs) from version 0.14.0 -> 0.16.0 (https://github.com/Rigellute/spotify-tui/commit/1ef37e7551b05ffba8b0a1eed2132ff9b97a15a6). I just tested downgrading back to 0.14.0 and the text is properly inverted when overtaken by the gauge bar. I think we ought to open an issue in tui-rs about this (if one does not already exist) and then maybe roll back the version until it gets fixed, unless we need 0.16.0 for some feature.
Author
Owner

@sputnick1124 commented on GitHub (Oct 5, 2021):

I opened an issue on the tui-rs repo (https://github.com/fdehau/tui-rs/issues/538) describing the regression.

As a stop gap measure for spotify-tui, instead of reverting to an earlier version of tui-rs, we can simply ignore the user's configured progress bar label color until this regression gets fixed. Essentially, we can change src/ui/mod.rs:1052 from

Style::default().fg(app.user_config.theme.playbar_progress_text),

to be

Style::default(), // .fg(app.user_config.theme.playbar_progress_text),  --- To be added back in when fdehau/tui-rs#538 is resolved 

instead. This will make the label default to the progress bar foreground color and it will be properly inverted when the progress overtakes the label.

<!-- gh-comment-id:934017120 --> @sputnick1124 commented on GitHub (Oct 5, 2021): I opened an issue on the tui-rs repo (https://github.com/fdehau/tui-rs/issues/538) describing the regression. As a stop gap measure for spotify-tui, instead of reverting to an earlier version of tui-rs, we can simply ignore the user's configured progress bar label color until this regression gets fixed. Essentially, we can change [src/ui/mod.rs:1052](https://github.com/Rigellute/spotify-tui/blob/ecddb5eb4fb441bf46075d44cf12cd2294a251c7/src/ui/mod.rs#L1052) from ```rust Style::default().fg(app.user_config.theme.playbar_progress_text), ``` to be ```rust Style::default(), // .fg(app.user_config.theme.playbar_progress_text), --- To be added back in when fdehau/tui-rs#538 is resolved ``` instead. This will make the label default to the progress bar foreground color and it will be properly inverted when the progress overtakes the label.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-tui#378
No description provided.