mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-26 16:15:55 +03:00
[GH-ISSUE #887] Progress bar "overlapping" track length #378
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#378
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MCT32 on GitHub (Sep 17, 2021).
Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/887
I've noticed since I've updated the track length indicator no longer changes its color when intercepting the progress bar. I used the word overlapping in the title to try to explain it.

@Takheer commented on GitHub (Sep 17, 2021):
I also have this issue after pausing and resuming a track:

@sputnick1124 commented on GitHub (Oct 3, 2021):
I'm seeing this as well. It appears that this has occurred due to an upgrade in the version of tui-rs from version 0.14.0 -> 0.16.0 (
github.com/Rigellute/spotify-tui@1ef37e7551). I just tested downgrading back to 0.14.0 and the text is properly inverted when overtaken by the gauge bar.I think we ought to open an issue in tui-rs about this (if one does not already exist) and then maybe roll back the version until it gets fixed, unless we need 0.16.0 for some feature.
@sputnick1124 commented on GitHub (Oct 5, 2021):
I opened an issue on the tui-rs repo (https://github.com/fdehau/tui-rs/issues/538) describing the regression.
As a stop gap measure for spotify-tui, instead of reverting to an earlier version of tui-rs, we can simply ignore the user's configured progress bar label color until this regression gets fixed. Essentially, we can change src/ui/mod.rs:1052 from
to be
instead. This will make the label default to the progress bar foreground color and it will be properly inverted when the progress overtakes the label.