mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-26 16:15:55 +03:00
[GH-ISSUE #611] Saved albums are not recognized when an artist's page is loaded without a search #247
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#247
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Utagai on GitHub (Oct 10, 2020).
Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/611
Seems like, if you search for an artist, then with a high probability, you will also find some or all of their albums as well. When this happens,
sptwill asynchronously dispatch an event for populating its knowledge of the user's saved albums.This works pretty well most of the time, but has two main issues:
Here's a screenshot of an artist I follow, that I found by searching:

Note that the saved albums are starred.
NOTE I'm running a fork of
sptwhere I have changed the glyph used for saved albums, because the heart wasn't rendering with the font I use. I'm considering filing another issue to make the symbol configurable for those who have non-unicode supporting fonts/environments like me, or may dislike the icon, etc, but this is not relevant.Here's a screenshot of the same artist that I navigated to from my saved artists:

NOTE I feel like it would make sense that the code would be analogous for saved tracks as well, but the current code only dispatches an event for caching the saved albums only. I'm assuming this omission was intentional, but it is a little odd so this issue may be applicable to tracks too.