[GH-ISSUE #593] Split 'local' actions from 'online' actions #244

Closed
opened 2026-02-28 14:48:00 +03:00 by kerem · 3 comments
Owner

Originally created by @Toaster192 on GitHub (Sep 28, 2020).
Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/593

What I mean is, I can't even pause the song when my internet gives up on me for a few seconds.

Does the app really have to send a request just to pause the song locally or is it because while any other request is being 'processed' (waits for the network request to come through) any other commands get put in queue (including 'local' ones like pausing the song)

Originally created by @Toaster192 on GitHub (Sep 28, 2020). Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/593 What I mean is, I can't even pause the song when my internet gives up on me for a few seconds. Does the app really have to send a request just to pause the song locally or is it because while any other request is being 'processed' (waits for the network request to come through) any other commands get put in queue (including 'local' ones like pausing the song)
kerem closed this issue 2026-02-28 14:48:00 +03:00
Author
Owner

@sputnick1124 commented on GitHub (Sep 28, 2020):

Yes, a request really does have to go out in order for a pause to happen. spt doesn't handle playback, it is just a front-end interface to spotify's web api.

Since the advent of async, there shouldn't be any blocking of local actions due to network delays since all network calls are now run in a non blocking context.

<!-- gh-comment-id:700000872 --> @sputnick1124 commented on GitHub (Sep 28, 2020): Yes, a request really does have to go out in order for a pause to happen. `spt` doesn't handle playback, it is just a front-end interface to spotify's web api. Since the advent of async, there shouldn't be any blocking of local actions due to network delays since all network calls are now run in a non blocking context.
Author
Owner

@Rigellute commented on GitHub (Sep 30, 2020):

As @sputnick1124 rightly says, there aren't really any 'local' actions in spotify-tui since everything must go through the spotify API (spotify-tui doesn't handle playback). So a network connection is required.

<!-- gh-comment-id:701520239 --> @Rigellute commented on GitHub (Sep 30, 2020): As @sputnick1124 rightly says, there aren't really any 'local' actions in spotify-tui since everything must go through the spotify API (spotify-tui doesn't handle playback). So a network connection is required.
Author
Owner

@kubukoz commented on GitHub (Dec 28, 2020):

One thing spotify-tui could be doing is make decisions on what the space button means based on the remote state - currently it seems to be basing that entirely on the local playback stat. Here's what I mean:

  1. (music is playing)
  2. tap space, tui knows it's playing so it sends a PAUSE request
  3. remote stops playing, hasn't responded yet so tui think it's playing
  4. tap space
  5. tui thinks it's playing so it sends a PAUSE request

In the ideal scenario, tui would check for the status every time before making a pause/play request, and use that to make the decision.

<!-- gh-comment-id:751558041 --> @kubukoz commented on GitHub (Dec 28, 2020): One thing spotify-tui could be doing is make decisions on what the space button means based on the remote state - currently it seems to be basing that entirely on the local playback stat. Here's what I mean: 1. (music is playing) 2. tap space, tui knows it's playing so it sends a PAUSE request 3. remote stops playing, hasn't responded yet so tui think it's playing 4. tap space 5. tui thinks it's playing so it sends a PAUSE request In the ideal scenario, tui would check for the status every time before making a pause/play request, and use that to make the decision.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-tui#244
No description provided.