mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-27 00:25:53 +03:00
[GH-ISSUE #593] Split 'local' actions from 'online' actions #244
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#244
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Toaster192 on GitHub (Sep 28, 2020).
Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/593
What I mean is, I can't even pause the song when my internet gives up on me for a few seconds.
Does the app really have to send a request just to pause the song locally or is it because while any other request is being 'processed' (waits for the network request to come through) any other commands get put in queue (including 'local' ones like pausing the song)
@sputnick1124 commented on GitHub (Sep 28, 2020):
Yes, a request really does have to go out in order for a pause to happen.
sptdoesn't handle playback, it is just a front-end interface to spotify's web api.Since the advent of async, there shouldn't be any blocking of local actions due to network delays since all network calls are now run in a non blocking context.
@Rigellute commented on GitHub (Sep 30, 2020):
As @sputnick1124 rightly says, there aren't really any 'local' actions in spotify-tui since everything must go through the spotify API (spotify-tui doesn't handle playback). So a network connection is required.
@kubukoz commented on GitHub (Dec 28, 2020):
One thing spotify-tui could be doing is make decisions on what the space button means based on the remote state - currently it seems to be basing that entirely on the local playback stat. Here's what I mean:
In the ideal scenario, tui would check for the status every time before making a pause/play request, and use that to make the decision.