[GH-ISSUE #26] Fatal exit when type not english characters #24

New issue

Closed

opened 2026-02-28 14:46:26 +03:00 by kerem · 4 comments

kerem commented

2026-02-28 14:46:26 +03:00

Owner

Originally created by @PxyUp on GitHub (Oct 8, 2019).
Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/26

When you try to find any not English characters application did fatal exit

Originally created by @PxyUp on GitHub (Oct 8, 2019). Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/26 When you try to find any not English characters application did fatal exit

kerem closed this issue

2026-02-28 14:46:26 +03:00

kerem commented

2026-02-28 14:46:27 +03:00

Author

Owner

@Rigellute commented on GitHub (Oct 8, 2019):

Huh interesting, could you share the characters you used that caused the fatal exit?

@Rigellute commented on GitHub (Oct 8, 2019): Huh interesting, could you share the characters you used that caused the fatal exit?

kerem commented

2026-02-28 14:46:27 +03:00

Author

Owner

@PxyUp commented on GitHub (Oct 8, 2019):

@Rigellute 'ыаываываайцайцайцайцайцаймямцу'
Any of that

@PxyUp commented on GitHub (Oct 8, 2019): @Rigellute 'ыаываываайцайцайцайцайцаймямцу' Any of that

kerem commented

2026-02-28 14:46:27 +03:00

Author

Owner

@fangyi-zhou commented on GitHub (Oct 8, 2019):

This is caused by inserting into a string outside word boundary, I'm submitting a PR to fix it

@fangyi-zhou commented on GitHub (Oct 8, 2019): This is caused by inserting into a string outside word boundary, I'm submitting a PR to fix it

kerem commented

2026-02-28 14:46:27 +03:00

Author

Owner

@filiphe commented on GitHub (Oct 16, 2019):

Here's a test that currently fails on "non-english" input.

#[test]
    fn test_input_handler_on_enter_non_english_text() {
        let mut app = App::new();

        app.input = "My tex".to_string();
        app.input_cursor_position = app.input.len().try_into().unwrap();

        handler(Key::Char('ö'), &mut app);
        handler(Key::Char('ä'), &mut app);
        handler(Key::Char('å'), &mut app);
        handler(Key::Char('á'), &mut app);
        handler(Key::Char('þ'), &mut app);


        assert_eq!(app.input, "My texöäåáþ".to_string());
    }

Result from cargo test

---- handlers::input::tests::test_input_handler_on_enter_non_english_text stdout ----
thread 'handlers::input::tests::test_input_handler_on_enter_non_english_text' panicked at 'assertion failed: self.is_char_boundary(idx)', src/liballoc/string.rs:1287:9

@filiphe commented on GitHub (Oct 16, 2019): Here's a test that currently fails on "non-english" input. ``` #[test] fn test_input_handler_on_enter_non_english_text() { let mut app = App::new(); app.input = "My tex".to_string(); app.input_cursor_position = app.input.len().try_into().unwrap(); handler(Key::Char('ö'), &mut app); handler(Key::Char('ä'), &mut app); handler(Key::Char('å'), &mut app); handler(Key::Char('á'), &mut app); handler(Key::Char('þ'), &mut app); assert_eq!(app.input, "My texöäåáþ".to_string()); } ``` Result from `cargo test` ``` ---- handlers::input::tests::test_input_handler_on_enter_non_english_text stdout ---- thread 'handlers::input::tests::test_input_handler_on_enter_non_english_text' panicked at 'assertion failed: self.is_char_boundary(idx)', src/liballoc/string.rs:1287:9 ```