mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-27 00:25:53 +03:00
[GH-ISSUE #576] Closing web client does not stop the play timer #238
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#238
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @meerasndr on GitHub (Sep 13, 2020).
Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/576
I'm not sure if the web app qualifies as an official Spotify client, but here goes:
When I close the Spotify tab on my browser, the play countdown keeps running in the terminal till the end of the track length, even though the audio itself stops. Tried this on both Firefox and Brave with the same result.
Is this a known issue?
PS- I'm able to start and pause from the Terminal, no problems. It displays the client correctly( Web player(Firefox)).
@sputnick1124 commented on GitHub (Sep 29, 2020):
Yep. It looks like we don't properly handle the possibility of the playback context disappearing:
github.com/Rigellute/spotify-tui@0e8f3723ad/src/network.rs (L310-L325)This should be as simple as adding an
Might be a great first issue for someone to tackle. I would be happy to help out if needed.
@meerasndr commented on GitHub (Sep 29, 2020):
Thanks. I can take a look at it!
@Rigellute commented on GitHub (Sep 30, 2020):
Nice!