mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-29 09:35:59 +03:00
[GH-ISSUE #533] Help menu flickers when viewing in vertical orientation #220
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#220
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @isaacdchan on GitHub (Jul 22, 2020).
Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/533
Currently have spt on a 1080 x 1920 screen. Problem disappears with small enough font size
Understand vertical orientation usage is probably the minority so no rush.
Screen flickers between these two screens:



With smaller font:
Thanks again for such a cool project!
@Rigellute commented on GitHub (Jul 22, 2020):
I also experience this - haven't found a fix yet.
Thanks for opening the issue 👍
@Nil-Cipher commented on GitHub (Jul 25, 2020):
I'm also having this issue.


@dp304 commented on GitHub (Oct 28, 2020):
Hi!
I'm also having this with a "standard" 80x24 terminal (my default).
The problem seems to be that the Cassowary solver (which is used by
tuito calculate the column widths in a table) has some non-determinism if the constraints cannot be satisfied; which is the case when the terminal is too narrow to hold all the columns.In its documentation, there is more explanation to this, as well as a suggested solution to a related problem.
Perhaps a similar fix could be applied to
tui: inTable::render(), one could add extra (stronger) constraints on the width ratio of neighbouring columns, but I'm not sure if this would actually work. Possibly related issues intui: fdehau/tui-rs#161, fdehau/tui-rs#314Until this problem is somehow handled in
tui, I suggest a workaround (PR coming up), where the rows of the table are formatted "manually" into one column.Another thing I've tried is playing around with the width constraints. For example, one could use
Constraint::Percentages instead ofConstraint::Lengths, but there are some problems with this:@Rigellute commented on GitHub (Oct 30, 2020):
Thank you for the insight into this @dp304, that is interesting ideed!
@Rigellute commented on GitHub (Oct 30, 2020):
Closed by #638