mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-26 08:05:57 +03:00
[GH-ISSUE #523] Rapidly seeking through song causes song to get "stuck" #214
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#214
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dvdmuckle on GitHub (Jul 10, 2020).
Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/523
If I try to rapidly seek through a song using
<or>numerous times in succession, the song will get stuck at whenever I started seeking and will constantly start seeking to that point instead of seeking back or ahead of that point.Video: https://asciinema.org/a/o7c0aue0g2np34HCReOQswjwr
I think what's going on is there's a client side calculation of where to seek to (current song position + fifteen seconds), however because the API call takes some time to go through, queuing up multiple seeks doesn't work, as the current song position is retrieved from the API as opposed to some local variable.
@Rigellute commented on GitHub (Jul 22, 2020):
Thank you for the asciinema!
I think a fix for this would be to "debounce" the seek, sum the total, and then make one api request with the final seek
@dp304 commented on GitHub (Oct 29, 2020):
See PR #640
There is a little latency before the actual seeking (up to 5s), but on the other hand, it is very light on API calls.
The visual feedback is quasi-instant though.
@dvdmuckle commented on GitHub (Oct 29, 2020):
That PR is exactly the solution to solve this issue, awesome! Once that's merged in this can be closed.