[PR #1046] [CLOSED] Update Cargo.lock & apply clippy suggestions #1143

Closed
opened 2026-02-28 14:54:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/1046
Author: @amaanq
Created: 11/28/2022
Status: Closed

Base: masterHead: master


📝 Commits (2)

  • 6d499ea apply clippy suggestions (minus assert_eqs -> assert for clarity)
  • 1c9cc2d update Cargo.lock (fixes some OpenSSL issues..)

📊 Changes

8 files changed (+663 additions, -534 deletions)

View changed files

📝 Cargo.lock (+641 -512)
📝 src/app.rs (+1 -1)
📝 src/cli/cli_app.rs (+2 -2)
📝 src/config.rs (+1 -1)
📝 src/handlers/input.rs (+1 -1)
📝 src/main.rs (+7 -7)
📝 src/ui/mod.rs (+9 -9)
📝 src/user_config.rs (+1 -1)

📄 Description

The Cargo.lock update was mainly to fix a bug when compiling on some Linux distros where OpenSSL was bumped to OpenSSL 3.

The clippy suggestions are a variety of fixes detected by cargo clippy, although I did not apply the ones to suggest using assert! instead of assert_eq! for some variable true/false cases, mainly because that's an opinionated choice on what feels clearer.

Thanks for the awesome software!

  • Amaan

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/1046 **Author:** [@amaanq](https://github.com/amaanq) **Created:** 11/28/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`6d499ea`](https://github.com/Rigellute/spotify-tui/commit/6d499ea6f3444f86ec565de60e9d95ce65528ff2) apply clippy suggestions (minus assert_eqs -> assert for clarity) - [`1c9cc2d`](https://github.com/Rigellute/spotify-tui/commit/1c9cc2dd00e8da6a6f1f0e4c40840d8e1bae2c83) update Cargo.lock (fixes some OpenSSL issues..) ### 📊 Changes **8 files changed** (+663 additions, -534 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+641 -512) 📝 `src/app.rs` (+1 -1) 📝 `src/cli/cli_app.rs` (+2 -2) 📝 `src/config.rs` (+1 -1) 📝 `src/handlers/input.rs` (+1 -1) 📝 `src/main.rs` (+7 -7) 📝 `src/ui/mod.rs` (+9 -9) 📝 `src/user_config.rs` (+1 -1) </details> ### 📄 Description The Cargo.lock update was mainly to fix a bug when compiling on some Linux distros where OpenSSL was bumped to OpenSSL 3. The clippy suggestions are a variety of fixes detected by `cargo clippy`, although I did not apply the ones to suggest using assert! instead of assert_eq! for some variable true/false cases, mainly because that's an opinionated choice on what feels clearer. Thanks for the awesome software! - Amaan --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:54:36 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-tui#1143
No description provided.