mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-26 16:15:55 +03:00
[PR #1046] [CLOSED] Update Cargo.lock & apply clippy suggestions #1143
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#1143
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Rigellute/spotify-tui/pull/1046
Author: @amaanq
Created: 11/28/2022
Status: ❌ Closed
Base:
master← Head:master📝 Commits (2)
6d499eaapply clippy suggestions (minus assert_eqs -> assert for clarity)1c9cc2dupdate Cargo.lock (fixes some OpenSSL issues..)📊 Changes
8 files changed (+663 additions, -534 deletions)
View changed files
📝
Cargo.lock(+641 -512)📝
src/app.rs(+1 -1)📝
src/cli/cli_app.rs(+2 -2)📝
src/config.rs(+1 -1)📝
src/handlers/input.rs(+1 -1)📝
src/main.rs(+7 -7)📝
src/ui/mod.rs(+9 -9)📝
src/user_config.rs(+1 -1)📄 Description
The Cargo.lock update was mainly to fix a bug when compiling on some Linux distros where OpenSSL was bumped to OpenSSL 3.
The clippy suggestions are a variety of fixes detected by
cargo clippy, although I did not apply the ones to suggest using assert! instead of assert_eq! for some variable true/false cases, mainly because that's an opinionated choice on what feels clearer.Thanks for the awesome software!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.