mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-25 23:55:53 +03:00
[PR #1010] Playlist pagination #1128
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#1128
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Rigellute/spotify-tui/pull/1010
Author: @ailac22
Created: 8/14/2022
Status: 🔄 Open
Base:
master← Head:feature/playlist_pagination📝 Commits (1)
0021006Added playlist pagination📊 Changes
9 files changed (+207 additions, -98 deletions)
View changed files
📝
src/app.rs(+34 -9)📝
src/cli/cli_app.rs(+10 -6)📝
src/handlers/made_for_you.rs(+1 -1)📝
src/handlers/playlist.rs(+53 -31)📝
src/handlers/search_results.rs(+2 -2)📝
src/handlers/track_table.rs(+53 -31)📝
src/main.rs(+1 -1)📝
src/network.rs(+51 -15)📝
src/ui/mod.rs(+2 -2)📄 Description
Added pagination to playlists. Now playlist pages can be scrolled with usual ctrl+u, ctrl+d keys, so all playlist and not just the 50 first ones will be available.
I'm aware that the author was planning a change in the program's structure that will possibly make this pr useless in the future, but for me the app is quite unusable without all my playlists. Also, unsure if my code is quite rust-like, specifically at the new functions in
ScrollableResultPages, or inget_current_user_playlists, but it gets the job done for now. Listing playlists withspt list --playlistsstill return only the first playlist page.Let me tell you what you think about it. Thanks.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.