[PR #826] [MERGED] Pressing `d` twice requires `q` twice to exit #1042

New issue

Closed

opened 2026-02-28 14:54:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:54:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/826
Author: @cobbinma
Created: 6/1/2021
Status: ✅ Merged
Merged: 8/23/2021
Merged by: @Rigellute

Base: master ← Head: multiple-d-clicks

📝 Commits (5)

35fa44e dedup selected device routes from nav stack
3ebee74 dedup any matching routes from nav stack
ee4d373 catch duplicate route id on push
9e5e4b1 remove return
e8116ff remove id from variable name

📊 Changes

1 file changed (+12 additions, -5 deletions)

View changed files

📝 src/app.rs (+12 -5)

📄 Description

Hi guys 👋,

First attempt at a PR here and attempted to resolve issue

Did this by deduping any routes on the navigation stack with matching ids.

The device selector popup can be opened multiple times by pressing d more than once.
To get back to the main menu, each of these needs to be closed separately by pressing q the same number of times.

It would be nicer if pressing q only once always goes back to the main menu.

E.g, actual behavior:

press d
press d
press q
You're seeing the device selector
expected behavior:

press d
press d
press q
You're seeing the main menu

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/826 **Author:** [@cobbinma](https://github.com/cobbinma) **Created:** 6/1/2021 **Status:** ✅ Merged **Merged:** 8/23/2021 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `multiple-d-clicks` --- ### 📝 Commits (5) - [`35fa44e`](https://github.com/Rigellute/spotify-tui/commit/35fa44ee0176c556a321417ea24b13d52fcecb6a) dedup selected device routes from nav stack - [`3ebee74`](https://github.com/Rigellute/spotify-tui/commit/3ebee74c3e23c2ea60841a7f2f54ec3e4c58238a) dedup any matching routes from nav stack - [`ee4d373`](https://github.com/Rigellute/spotify-tui/commit/ee4d37362b42128f3c00222b083d8172a66c3b9a) catch duplicate route id on push - [`9e5e4b1`](https://github.com/Rigellute/spotify-tui/commit/9e5e4b17f9565626ae9cad33a34962f88a975e96) remove return - [`e8116ff`](https://github.com/Rigellute/spotify-tui/commit/e8116ff52f22425a09cfb3bc8656aa79015d1ad5) remove id from variable name ### 📊 Changes **1 file changed** (+12 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/app.rs` (+12 -5) </details> ### 📄 Description Hi guys 👋, First attempt at a PR here and attempted to resolve [issue](https://github.com/Rigellute/spotify-tui/issues/821) Did this by `dedup`ing any routes on the navigation stack with matching ids. --- The device selector popup can be opened multiple times by pressing `d` more than once. To get back to the main menu, each of these needs to be closed separately by pressing `q` the same number of times. It would be nicer if pressing `q` only once always goes back to the main menu. E.g, actual behavior: press `d` press `d` press `q` You're seeing the device selector expected behavior: press `d` press `d` press `q` You're seeing the main menu --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>