[PR #775] [CLOSED] feat: Allow wayland builds without xcb dependency #1029

New issue

Closed

opened 2026-02-28 14:54:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:54:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/775
Author: @xanderio
Created: 3/29/2021
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

cb86506 feat: Allow wayland builds without xcb dependency

📊 Changes

3 files changed (+21 additions, -1 deletions)

View changed files

📝 Cargo.toml (+6 -1)
📝 src/app.rs (+13 -0)
📝 src/ui/help.rs (+2 -0)

📄 Description

The arbout carte is used to interact with the system clipboard. This
however imposes a dependency on xcb on the crate for Linux/Unix builds.

On a pure Wayland system this is undesirable as interaction with the
system clipboard via xcb in only possible if the user runs a xwayland
server. This cause spotify-cli to require a dependency to a x11 c lib
without providing any functionally to the user.

This change intoduces to new cargo features to spotify-cli: x11 and
wayland.

The x11 feature is in the default feature and will preserve the
current application behavior.

The wayland feature will disable the dependency onto arboard and use
#[cfg(feature = "wayland")] attributes to disable code using this
crate, as well as any reference from the help menu to any copy
functionally.

I currently plan to investigate how to bring this behavior back to the wayland platform.

Looking forward to your code review. :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/775 **Author:** [@xanderio](https://github.com/xanderio) **Created:** 3/29/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`cb86506`](https://github.com/Rigellute/spotify-tui/commit/cb865065846e127d91e3ad2d60e511fb1a2bf396) feat: Allow wayland builds without xcb dependency ### 📊 Changes **3 files changed** (+21 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+6 -1) 📝 `src/app.rs` (+13 -0) 📝 `src/ui/help.rs` (+2 -0) </details> ### 📄 Description The arbout carte is used to interact with the system clipboard. This however imposes a dependency on xcb on the crate for Linux/Unix builds. On a pure Wayland system this is undesirable as interaction with the system clipboard via xcb in only possible if the user runs a xwayland server. This cause spotify-cli to require a dependency to a x11 c lib without providing any functionally to the user. This change intoduces to new cargo features to spotify-cli: `x11` and `wayland`. The `x11` feature is in the default feature and will preserve the current application behavior. The `wayland` feature will disable the dependency onto arboard and use `#[cfg(feature = "wayland")]` attributes to disable code using this crate, as well as any reference from the help menu to any copy functionally. I currently plan to investigate how to bring this behavior back to the wayland platform. Looking forward to your code review. :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>